Opened 11 years ago

Closed 5 years ago

#7176 closed defect (fixed)

slider: should round the valuenow to 2 decimal places before setting

Reported by: Becky Gibson Owned by: bill
Priority: high Milestone: 1.11
Component: Accessibility Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

When the window-eyes screen reader speaks the slider value it speaks the entire value provided - we should probably round this to two decimal places. JAWS already rounds the value to a whole number.

I'm not sure what affect rounding the value could have on its meaning? Perhaps the rounding should only occur if a min has been set to 0 and a max to 100?

Change History (10)

comment:1 Changed 11 years ago by Becky Gibson

Milestone: tbd1.3

comment:2 Changed 11 years ago by Douglas Hays

I'm assuming this is talking about rounding the valuenow value parameter to dijit.setWaiState. I think rounding to N fractional decimal digits would be OK and not require a new parameter if you could come up with a good formula - though a parameter would clearly be easier to implement.
I'd think for 0 to 100, that 2 digits would be OK, so 0.01 and 99.99
For 0 to 10000, maybe 0 fractional digits are needed.
For 0 to 1, I think you'd need 0.0001 and 0.9999 Similarly for 99 to 100, would you need 99.0001 and 99.9999?

comment:3 Changed 11 years ago by Becky Gibson

Milestone: 1.31.4

comment:4 Changed 11 years ago by bill

Hmm, this seems like what the discreteValues parameter is already for, assuming that the math works out? For example for a slider from 0 to 100, if discreteValues==10 then valuenow is 10,20,30,40, etc.

Admittedly if the slider goes from 0 to 1 w/discreteValues=3 then you will get 0.33333333333 as a value.

BTW what you are talking about is called "rounding to 2 significant dijits", see http://en.wikipedia.org/wiki/Significant_figures

comment:5 Changed 10 years ago by Becky Gibson

Milestone: 1.4future

comment:6 Changed 9 years ago by Chris Mitchell

Owner: changed from Becky Gibson to Douglas Hays

reassign due to inactive committer. please triage accordingly.

comment:7 Changed 6 years ago by Douglas Hays

Owner: Douglas Hays deleted
Status: newassigned

comment:8 Changed 6 years ago by Douglas Hays

Status: assignedopen

comment:9 Changed 5 years ago by bill

Milestone: future1.11
Owner: set to bill
Status: openassigned

comment:10 Changed 5 years ago by Bill Keese <bill@…>

Resolution: fixed
Status: assignedclosed

In 12d4980e4f1787c9d7e6913a4d28e58d170096fc/dijit:

Error: Processor CommitTicketReference failed
Unsupported version control system "git": Can't find an appropriate component, maybe the corresponding plugin was not enabled? 
Note: See TracTickets for help on using tickets.