Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7159 closed defect (fixed)

Change dojo.isXxxx properties to use undefined instead of 0

Reported by: Adam Peller Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: Core Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

Need to write up in release notes, since this will break anyone who does a direct comparison against zero.

Attachments (1)

7159.patch​ (3.4 KB) - added by Adam Peller 11 years ago.
needs review. Also fixes #7153

Download all attachments as: .zip

Change History (6)

Changed 11 years ago by Adam Peller

Attachment: 7159.patch​ added

needs review. Also fixes #7153

comment:1 Changed 11 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [14422]) use undefined for falsey results from dojo.isXxxx methods like dojo.isIE, instead of 0. Fixes #7159, #7153

comment:2 Changed 11 years ago by Adam Peller

(In [14423]) simplify IE8 check. Refs #7159 !strict

comment:3 Changed 11 years ago by Adam Peller

(In [14424]) simplify IE version check. Refs #7159 !strict

comment:4 Changed 11 years ago by Adam Peller

(In [14425]) simplify IE version check. Refs #7159 !strict

comment:5 Changed 11 years ago by Adam Peller

(In [15982]) Re-commit some changes that were lost in the rollback. Refs #7159 !strict

Note: See TracTickets for help on using tickets.