Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7155 closed enhancement (fixed)

TabContainer: support spacer bigger than 1px with border

Reported by: nonken Owned by: nonken
Priority: high Milestone: 1.2
Component: Dijit Version: 1.1.1
Keywords: TabContainer, tabstripe, left/right borders Cc:
Blocked By: Blocking:

Description (last modified by bill)

When having a spacer between the tab labels and the tab content bigger than 1px (as in soria and nihilo) you can not get rid of the outer border without having a sort of gap at the left and right of the stripe, we need to do some minor template changes to support that behavior

Change History (16)

comment:1 Changed 11 years ago by nonken

Keywords: tabstripe added; tabstripbe removed

comment:2 Changed 11 years ago by nonken

(In [14396]) fixed CSS to allow setting bgColor on tabStripe, its not the most optimal fix and probaly needs some refactoring (see #7155) to save image loading, fixes #7154

comment:3 Changed 11 years ago by bill

Component: GeneralDijit
Description: modified (diff)
Milestone: 1.31.2
Owner: changed from nonken to bill
Status: newassigned
Summary: tabContainer suport tabStripe bigger than 1px with borderTabContainer: suport spacer bigger than 1px with border

comment:4 Changed 11 years ago by bill

Owner: changed from bill to nonken
Status: assignednew
Summary: TabContainer: suport spacer bigger than 1px with borderTabContainer: support spacer bigger than 1px with border

oops, didn't mean to accept this... nonken should add the spacer div to the template.

comment:5 Changed 11 years ago by bill

BTW I don't think this is just a template change. If you add a new spacer <div> between the tab labels and the tab content, then in order to get it to appear in the right position in all TabContainer layouts (top, bottom, left, right), would need to call layoutChildren() w/three arguments instead of two... and doing that doesn't solve the problem of noLayout mode, when layoutChildren() isn't even called.

Perhaps it can be implemented via a margin between the tab labels and tab content. Or I suppose alternately by using the current implementation w/a gif file showing a fake border. Or, maybe just having a thick border at the bottom of the tab labels?

comment:6 Changed 11 years ago by nonken

(In [14569]) added template changes, code changes to support tabStripe and flexible spacer, refs #7155

comment:7 Changed 11 years ago by nonken

(In [14570]) Theme cleanup and addition of tabStrip, tabSpacer specific css, refs #7155

comment:8 Changed 11 years ago by nonken

(In [14571]) Theme cleanup and addition of tabStrip, tabSpacer specific css, refs #7155

comment:9 Changed 11 years ago by nonken

(In [14572]) Theme cleanup and addition of tabStrip, tabSpacer specific css, refs #7155

comment:10 Changed 11 years ago by nonken

(In [14573]) Fixed tab specific css for contentpane, refs #7155

comment:11 Changed 11 years ago by nonken

Resolution: fixed
Status: newclosed

(In [14574]) added spacer image for tab sizing, fixes #7155

comment:12 Changed 11 years ago by nonken

(In [14575]) Removes redundant ie specific CSS for rtl, refs #7155

comment:13 Changed 11 years ago by nonken

(In [14582]) Additional fixes for tests, refs #7155

comment:14 Changed 11 years ago by nonken

(In [14583]) removed blank image and use dojo/resources/blank.gif instead, refs #7155

comment:15 Changed 11 years ago by bill

(In [14595]) Use existing attribute name _blankGif rather than new one. Refs #7155 !strict.

comment:16 Changed 11 years ago by nonken

(In [14861]) moved spacer image out of label span, refs #7155

Note: See TracTickets for help on using tickets.