#7155 closed enhancement (fixed)
TabContainer: support spacer bigger than 1px with border
| Reported by: | nonken | Owned by: | nonken |
|---|---|---|---|
| Priority: | high | Milestone: | 1.2 |
| Component: | Dijit | Version: | 1.1.1 |
| Keywords: | TabContainer, tabstripe, left/right borders | Cc: | |
| Blocked By: | Blocking: |
Description (last modified by )
When having a spacer between the tab labels and the tab content bigger than 1px (as in soria and nihilo) you can not get rid of the outer border without having a sort of gap at the left and right of the stripe, we need to do some minor template changes to support that behavior
Change History (16)
comment:1 Changed 12 years ago by
| Keywords: | tabstripe added; tabstripbe removed |
|---|
comment:2 Changed 12 years ago by
comment:3 Changed 11 years ago by
| Component: | General → Dijit |
|---|---|
| Description: | modified (diff) |
| Milestone: | 1.3 → 1.2 |
| Owner: | changed from nonken to bill |
| Status: | new → assigned |
| Summary: | tabContainer suport tabStripe bigger than 1px with border → TabContainer: suport spacer bigger than 1px with border |
comment:4 Changed 11 years ago by
| Owner: | changed from bill to nonken |
|---|---|
| Status: | assigned → new |
| Summary: | TabContainer: suport spacer bigger than 1px with border → TabContainer: support spacer bigger than 1px with border |
oops, didn't mean to accept this... nonken should add the spacer div to the template.
comment:5 Changed 11 years ago by
BTW I don't think this is just a template change. If you add a new spacer <div> between the tab labels and the tab content, then in order to get it to appear in the right position in all TabContainer layouts (top, bottom, left, right), would need to call layoutChildren() w/three arguments instead of two... and doing that doesn't solve the problem of noLayout mode, when layoutChildren() isn't even called.
Perhaps it can be implemented via a margin between the tab labels and tab content. Or I suppose alternately by using the current implementation w/a gif file showing a fake border. Or, maybe just having a thick border at the bottom of the tab labels?
comment:6 Changed 11 years ago by
comment:7 Changed 11 years ago by
comment:8 Changed 11 years ago by
comment:9 Changed 11 years ago by
comment:11 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
(In [14396]) fixed CSS to allow setting bgColor on tabStripe, its not the most optimal fix and probaly needs some refactoring (see #7155) to save image loading, fixes #7154