Opened 11 years ago

Closed 11 years ago

#7153 closed defect (fixed)

The "dojo.isQuirks" is always true if browser is not IE

Reported by: notion Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: Core Version: 1.1.1
Keywords: dojo core browser environment Cc:
Blocked By: Blocking:

Description

Hi,

in Firefox, Safari and Opera the variable "dojo.isQuirks" is always true. Line: 132 in "hostenv_browser.js" checks if "document.compatMode" is something like: "BackCompat?", "QuirksMode?" OR "d.isIE < 6". In these browsers the last check will always return a true, because "d.isIE" returns 0.

I've tested this behaviour in the following environments:

Internet Explorer 6: isQuirks = true (BackCompat?) Internet Explorer 7: isQuirks = false (CSS1Compat) Mozilla Firefox 3.0: isQuirks = true (CSS1Compat) Safari 3.1.1: isQuirks = true (CSS1Compat)

OS: Microsoft Windows XP (SP2) Dojo: 1.1.1 (13707)

best regards André

Change History (3)

comment:1 Changed 11 years ago by Adam Peller

Milestone: tbd1.2

sounds like something we should resolve SRTL. We probably shouldn't even bother checking for IE<6 anymore, since it's not supported.

We also should reconsider using NaN instead of 0 to avoid this bug in the future.

comment:2 Changed 11 years ago by Adam Peller

Owner: changed from anonymous to Adam Peller
Status: newassigned

comment:3 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: assignedclosed

(In [14422]) use undefined for falsey results from dojo.isXxxx methods like dojo.isIE, instead of 0. Fixes #7159, #7153

Note: See TracTickets for help on using tickets.