dojo.data.ItemFileWriteStore: possible problem when calling store.revert()

[Nathan Toone]

This is from rgl on IRC:

The attached file contains an example (my first attempt at using it *G*) using DataGrid? and ItemFileWriteStore?; After you run the next steps, it ends with something I wasn't expecting:

1. Click Append Row
2. Select the appended row on the grid
3. Click Delete Selected Rows
4. Click Revert
5. For some reason the grid is not empty

[Nathan Toone]

I have confirmed that this also occurs if you have an IFWS and call: store.newItem(); store.deleteItem(); store.revert();

It would be expected (since no save has occured) that the store should be empty - however, deleting a newly-created item and then reverting retains the newly-created item.

[bitranch]

I just bumped into this yesterday. The problem is that the revert actions in ItemFileWriteStore.revert() are in reverse order.

Changes should be reverted in the order: deleted, modified, new. (Currently they're reverted in the order: new, modified, deleted. So a new item that's later either modified or deleted will be reverted by the "new" block, then re-inserted by the modified/delete revert.)

Swapping the new and delete blocks in revert() should fix the problem.

[Jared Jurkiewicz]

Reversing the order definitely fixes it. Running tests now on IE, Firefox, and Safari to verify it doesn't break anything. Will submit patches to this tracker, then commit the change.

[Jared Jurkiewicz]

Tested on:

Safari 3.1

IE 6

Firefox 2.0.0.16

[Jared Jurkiewicz]

(In [14455]) Fixing issue with revert. \!strict refs #7145

[Jared Jurkiewicz]

(In [14456]) Fixing issue with revert. \!strict fixes #7145