Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#714 closed enhancement (fixed)

[patch][cla] DropdownContainer.js outer div id patch

Reported by: cfranks@… Owned by: dylan
Priority: high Milestone:
Component: Widgets Version: 0.3
Keywords: patch Cc:
Blocked By: Blocking:

Description

It'd be nice if the outer div created by the DropdownContainer.js could have an id assigned to it, to help with layout, styling, etc.

Attached is a patch for a a suggested implementation src/widget/DropdownContainer.js

The diff is against svn version 4023

Attachments (1)

DropdownContainer.js.patch​ (1.3 KB) - added by cfranks@… 13 years ago.

Download all attachments as: .zip

Change History (8)

Changed 13 years ago by cfranks@…

Attachment: DropdownContainer.js.patch​ added

comment:1 Changed 13 years ago by dylan

Keywords: patch added
Milestone: → 0.4
Owner: changed from anonymous to bill

please see if this patch is valid or not.

comment:2 Changed 13 years ago by dylan

Owner: changed from bill to dylan
Status: new → assigned
Summary: DropdownContainer.js outer div id patch → [patch] DropdownContainer.js outer div id patch

comment:3 Changed 13 years ago by dylan

hmm, I think you really just want a way to attach the id to the domNode. Is there really a reason to call this wrapperNode?

comment:4 Changed 13 years ago by dylan

Summary: [patch] DropdownContainer.js outer div id patch → [patch][need cla] DropdownContainer.js outer div id patch

No CLA on file, but not really necessary as it is a bug (id not getting transferred to the domNode).

comment:5 Changed 13 years ago by dylan

Summary: [patch][need cla] DropdownContainer.js outer div id patch → [patch][cla] DropdownContainer.js outer div id patch

comment:6 Changed 13 years ago by dylan

Resolution: → fixed
Status: assigned → closed

(In [5694]) fixes #714, id not getting copied from markup to dropdown

comment:7 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.