Opened 11 years ago

Closed 11 years ago

#7128 closed defect (fixed)

In dojox.math, the factorial function is misspelled as "factoral"

Reported by: enzo Owned by: Tom Trenka
Priority: high Milestone: 1.2
Component: Dojox Version: 1.1.1
Keywords: Cc: Tom Trenka
Blocked By: Blocking:

Description

It may be advisable to rename it as "factorial", and add a "factoral" function that just return the former in order to preserve compatibility.

Attachments (1)

_base.diff.js (967 bytes) - added by nic 11 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 11 years ago by Tom Trenka

Owner: changed from anonymous to Tom Trenka

comment:2 Changed 11 years ago by Tom Trenka

Milestone: tbdfuture

comment:3 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: newclosed

(In [14368]) Correct typo in method name "factoral" -> "factorial". It's experimental code, so users will have to migrate. Better now than later. Fixes #7128

comment:4 Changed 11 years ago by Adam Peller

Component: GeneralDojox
Milestone: future1.2

Changed 11 years ago by nic

Attachment: _base.diff.js added

comment:5 Changed 11 years ago by nic

"factoral": five occurencies in _base.js
!0 is defined = 1

Nicola Rizzo

[ccla] nicola@…

comment:6 Changed 11 years ago by nic

Resolution: fixed
Status: closedreopened

comment:7 in reply to:  5 Changed 11 years ago by nic

Replying to nic:

"factoral": five occurencies in _base.js
!0 is defined = 1

Nicola Rizzo

[ccla] nicola@…

0! = 1

not !0 :)

comment:8 Changed 11 years ago by Adam Peller

Resolution: fixed
Status: reopenedclosed

(In [14374]) Fix factorial, hopefully correctly this time. thanks, nic. Fixes #7128

Note: See TracTickets for help on using tickets.