Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#7115 closed defect (fixed)

this vs. self mismatch in DropDownButton's popup onClose args

Reported by: humbletim Owned by: bill
Priority: high Milestone: 1.2
Component: Dijit - Form Version: 1.1.1
Keywords: dijit.form.Button dijit.form.DropDownButton Cc: tdedischew@…
Blocked By: Blocking:

Description

in dijit/form/Button.js @ _openDropdown:249

			onCancel: function(){
				self._closeDropDown(true);
			},
			onClose: function(){
				dropDown.domNode.style.width = oldWidth;
				self.popupStateNode.removeAttribute("popupActive");
				this._opened = false;
			}

this._opened = false; should be self._opened = false;

Change History (3)

comment:1 Changed 11 years ago by bill

Component: GeneralDijit
Milestone: 1.2
Owner: changed from anonymous to bill
Status: newassigned

thanks for catching that, will fix

comment:2 Changed 11 years ago by bill

Resolution: fixed
Status: assignedclosed

(In [14272]) fix typo. fixes #7115. !strict

comment:3 Changed 8 years ago by bill

Component: DijitDijit - Form
Note: See TracTickets for help on using tickets.