Opened 11 years ago

Closed 11 years ago

#7090 closed enhancement (fixed)

Add ability to pass extra parameters to dojo.parser.instantiate

Reported by: Nathan Toone Owned by: Nathan Toone
Priority: high Milestone: 1.3
Component: Parser Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

In order to override or manually specify things like dojoType, or other attributes, it would be really nice to have an additional parameter to dojo.parser.instantiate which will override those values specified on the node

Attachments (2)

parser.diff (1.8 KB) - added by nathan 11 years ago.
parser.2.diff (1.8 KB) - added by nathan 11 years ago.
Update with more accurate comment

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by nathan

Attachment: parser.diff added

comment:1 Changed 11 years ago by bill

Looks good to me.

Oh, the comment is backwards, isn't it?

// mixin: Object
//		An object that will be mixed in with each node in the array.
//		Values in the node, if they exist, will override values in this
//		variable.

but other than that looks good.

Changed 11 years ago by nathan

Attachment: parser.2.diff added

Update with more accurate comment

comment:2 Changed 11 years ago by nathan

Status: newassigned

comment:3 Changed 11 years ago by nathan

Milestone: 1.21.3

comment:4 Changed 11 years ago by Nathan Toone

Owner: changed from nathan to Nathan Toone
Status: assignednew

comment:5 Changed 11 years ago by Nathan Toone

Reporter: changed from nathan to Nathan Toone

comment:6 Changed 11 years ago by bill

See also #5230.

comment:7 Changed 11 years ago by Nathan Toone

Now that 1.2 has shipped, any objections to applying this patch now to trunk?

comment:8 Changed 11 years ago by bill

Fine w/me, go ahead.

comment:9 Changed 11 years ago by Nathan Toone

Resolution: fixed
Status: newclosed

fixed in [15650]

Note: See TracTickets for help on using tickets.