Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7085 closed defect (invalid)

[CLA][PATCH] dijit.form._FormMixin has no superclass so remove inherithed calls

Reported by: guest Owned by:
Priority: high Milestone: 1.2
Component: Dijit Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

dijit.form._FormMixin has no superclass but startup method added in revision 14161 call inherithed.
This gives me a too much recursion error.

Attached patch simply remove

this.inherited(arguments);

from startup method.

Attachments (1)

form.patch (387 bytes) - added by guest 11 years ago.
Created by Alessandro Ferrari

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by guest

Attachment: form.patch added

Created by Alessandro Ferrari

comment:1 Changed 11 years ago by bill

Resolution: invalid
Status: newclosed

dijit.form._FormMixin is a mixin (hence the name), and the class that it gets mixed into will have a superclass.

Are you seeing an actual problem?

comment:2 in reply to:  1 Changed 11 years ago by guest

I had a complex situation and firebug throw a "too much recursion" originating from dijit.form._FormMixin.startup's "this.inherited(arguments);" line and looping forever in _findMethod .
Now I've better understood inherited's behavior (still sound a strange way to walk inheritance tree to me) and bill is right.
Sorry for the wrong ticket.

BTW i fixed "too much recursion" in an other way in my code (still not sure to have solved the real root of the problem)

Note: See TracTickets for help on using tickets.