Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7074 closed defect (fixed)

Loading dojox.analytics.Urchin before dojox.analytics doesn't work

Reported by: guest Owned by: Dustin Machi
Priority: high Milestone: 1.2
Component: Dojox Version: 1.1.1
Keywords: analytics Cc: dante
Blocked By: Blocking:

Description

If you load in dojox.analytics.Urchin and then dojox.analytics then Urchin is no longer available because in dojox.analytics._base it has the following:

dojox.analytics = { ... };

Suggested fix is to use mixin instead:

dojo.mixin(dojox.analytics, { ... });

Change History (4)

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from Adam Peller to Dustin Machi

comment:2 Changed 11 years ago by Dustin Machi

Resolution: fixed
Status: newclosed

(In [14273]) make sure base is loaded before urchin for analyitics. fixes #7074

comment:3 Changed 11 years ago by dante

(In [14281]) refs #7074 - Urchin doesn't use/need anything from dojox.analytics except the namespace, which _base destroys. Requiring _base before Urchin fixes the problem. No need to always include _base code in Urchin -- it is simply unnecessary code. Documenting the extremly unlikly usecase where a user would want Urchin AND local tracking, and keeping Urchin small + dependency free

comment:4 Changed 11 years ago by bill

Milestone: 1.2

marking tickets closed in the last three months w/blank milestone to milestone 1.2.

Note: See TracTickets for help on using tickets.