Opened 11 years ago

Closed 10 years ago

#7027 closed enhancement (fixed)

[cla][patch] add href support for Tooltip as a dojox.widget.DynamicTooltip

Reported by: guest Owned by: dante
Priority: high Milestone: 1.4
Component: DojoX Widgets Version: 1.1.1
Keywords: tooltip href Cc: attila.lendvai@…
Blocked By: Blocking:

Description

i've ported my stuff to svn head and i was badly missing the href support for Tooltip.

please find it attached, ready to be put in dojox/widget/

but i think the right thing would be to add those 10 lines to Tooltip itself, but i leave the decision up to those who define where the project is going.

hth,

  • attila

ps: i have my cla signed from the v0.4 times.

Attachments (2)

DynamicTooltip.js (1.3 KB) - added by guest 11 years ago.
DynamicTooltip? with href support
DynamicTooltip.patch (10.6 KB) - added by Josh Trutwin 11 years ago.
Patch against trunk to add dijit.widget.DynamicTooltip? and test artifacts.

Download all attachments as: .zip

Change History (11)

Changed 11 years ago by guest

Attachment: DynamicTooltip.js added

DynamicTooltip? with href support

comment:1 Changed 11 years ago by dante

Milestone: 1.3
Status: newassigned
Summary: href support for Tooltip as a dojox.widget.DynamicTooltip[cla][patch] add href support for Tooltip as a dojox.widget.DynamicTooltip

wow, yeah these kinds of plugins should at least be available in dojox.widget. [cla] Lendvai, Attila

comment:2 Changed 11 years ago by bill

Milestone: 1.3future

comment:3 Changed 11 years ago by Josh Trutwin

I'll take a look at getting this release ready.

comment:4 Changed 11 years ago by Adam Peller

Milestone: future1.4

this patch shouldn't rot. moving back from 'future'. if trutwijd can get it together for 1.3 marked dojo.experimental, that's ok, too.

comment:5 Changed 11 years ago by Josh Trutwin

Please add wildbill to CC as he helped me with some of this and is the author of dijit.Tooltip.

Attaching patch - notes:

  1. added support for preventCache param for xhrGet and refresh() method to force new download on next show
  2. if no href param passed, should act as regular dijit.Tooltip
  3. should work with attr('href', 'foo') to change href, forces new content download

TODOs:

  1. better to maybe inherit from ContentPane? instead of trying to re-do some of this functionality?
  2. should there be an error: handler on the XHR?
  3. cancelling in flight?

Test page is basically copy of dijit.Tooltip tests with some specific tests for DynamicTooltip? added to top.

Thanks!

Josh

Changed 11 years ago by Josh Trutwin

Attachment: DynamicTooltip.patch added

Patch against trunk to add dijit.widget.DynamicTooltip? and test artifacts.

comment:6 Changed 11 years ago by Josh Trutwin

wildbill/phiggins - Too late to include in 1.3?

comment:7 Changed 11 years ago by Josh Trutwin

11:55 < trutwijd_afk> peller: dojox.widget.DynamicTooltip? gonna make it into 1.3? ;) 11:55 < peller> trutwijd_afk: beats me 11:56 < peller> trutwijd_afk: who owns it at this point? probably not since we just had what we think is our last beta? 11:56 < trutwijd_afk> peller: hmm - thought you were ok if marked experimental - maybe I was chatting with someone else.... 11:57 < peller> trutwijd_afk: yeah, I've been pretty lenient on that myself... 11:57 < peller> trutwijd_afk: weren't we going to get it reviewed by the tooltip owner? (guess that would be wildbill) 11:57 < trutwijd_afk> peller: bill helped me out with it, but I guess I wouldn't say he formally reviewed it or anything. not sure the process 11:58 < peller> for dojox, there isn't much process. just looking for some consensus 11:58 < peller> but you'd typically go through the subproject owner (and, in this case, if it has to do with existing code, the owner of that code) 11:58 < peller> dojox.widget is probably phiggins. 11:59 < trutwijd_afk> peller: it is 11:59 < trutwijd_afk> I'll make a comment on the trac about it - thx

comment:8 Changed 11 years ago by Josh Trutwin

oops - kill last comment - try this instead:

11:55 < trutwijd_afk> peller: dojox.widget.DynamicTooltip gonna make it into 1.3?  ;)
11:55 < peller> trutwijd_afk: beats me
11:56 < peller> trutwijd_afk: who owns it at this point?  probably not since we just had what we think is our last beta?
11:56 < trutwijd_afk> peller: hmm - thought you were ok if marked experimental - maybe I was chatting with someone else....
11:57 < peller> trutwijd_afk: yeah, I've been pretty lenient on that myself...
11:57 < peller> trutwijd_afk: weren't we going to get it reviewed by the tooltip owner? (guess that would be wildbill)
11:57 < trutwijd_afk> peller: bill helped me out with it, but I guess I wouldn't say he formally reviewed it or anything.  not sure the process
11:58 < peller> for dojox, there isn't much process.  just looking for some consensus
11:58 < peller> but you'd typically go through the subproject owner (and, in this case, if it has to do with existing code, the owner of that code)
11:58 < peller> dojox.widget is probably phiggins.
11:59 < trutwijd_afk> peller: it is
11:59 < trutwijd_afk> I'll make a comment on the trac about it - thx

comment:9 Changed 10 years ago by dante

Resolution: fixed
Status: assignedclosed

(In [20167]) adding in DynamicTooltip? courtesy trutwijd - small fixes/cleanups, removed a deprecated stub, added a doc stub indicating experimental dojox component. fixes #7027

Note: See TracTickets for help on using tickets.