[cla][patch] add href support for Tooltip as a dojox.widget.DynamicTooltip

[guest]

i've ported my stuff to svn head and i was badly missing the href support for Tooltip.

please find it attached, ready to be put in dojox/widget/

but i think the right thing would be to add those 10 lines to Tooltip itself, but i leave the decision up to those who define where the project is going.

hth,

• attila

ps: i have my cla signed from the v0.4 times.

[guest]

DynamicTooltip? with href support

[dante]

wow, yeah these kinds of plugins should at least be available in dojox.widget. [cla] Lendvai, Attila

[Josh Trutwin]

I'll take a look at getting this release ready.

[Adam Peller]

this patch shouldn't rot. moving back from 'future'. if trutwijd can get it together for 1.3 marked dojo.experimental, that's ok, too.

[Josh Trutwin]

Please add wildbill to CC as he helped me with some of this and is the author of dijit.Tooltip.

Attaching patch - notes:

1. added support for preventCache param for xhrGet and refresh() method to force new download on next show
2. if no href param passed, should act as regular dijit.Tooltip
3. should work with attr('href', 'foo') to change href, forces new content download

TODOs:

1. better to maybe inherit from ContentPane? instead of trying to re-do some of this functionality?
2. should there be an error: handler on the XHR?
3. cancelling in flight?

Test page is basically copy of dijit.Tooltip tests with some specific tests for DynamicTooltip? added to top.

Thanks!

Josh

[Josh Trutwin]

Patch against trunk to add dijit.widget.DynamicTooltip? and test artifacts.

[Josh Trutwin]

wildbill/phiggins - Too late to include in 1.3?

[Josh Trutwin]

11:55 < trutwijd_afk> peller: dojox.widget.DynamicTooltip? gonna make it into 1.3? ;) 11:55 < peller> trutwijd_afk: beats me 11:56 < peller> trutwijd_afk: who owns it at this point? probably not since we just had what we think is our last beta? 11:56 < trutwijd_afk> peller: hmm - thought you were ok if marked experimental - maybe I was chatting with someone else.... 11:57 < peller> trutwijd_afk: yeah, I've been pretty lenient on that myself... 11:57 < peller> trutwijd_afk: weren't we going to get it reviewed by the tooltip owner? (guess that would be wildbill) 11:57 < trutwijd_afk> peller: bill helped me out with it, but I guess I wouldn't say he formally reviewed it or anything. not sure the process 11:58 < peller> for dojox, there isn't much process. just looking for some consensus 11:58 < peller> but you'd typically go through the subproject owner (and, in this case, if it has to do with existing code, the owner of that code) 11:58 < peller> dojox.widget is probably phiggins. 11:59 < trutwijd_afk> peller: it is 11:59 < trutwijd_afk> I'll make a comment on the trac about it - thx

[Josh Trutwin]

oops - kill last comment - try this instead:

11:55 < trutwijd_afk> peller: dojox.widget.DynamicTooltip gonna make it into 1.3?  ;)
11:55 < peller> trutwijd_afk: beats me
11:56 < peller> trutwijd_afk: who owns it at this point?  probably not since we just had what we think is our last beta?
11:56 < trutwijd_afk> peller: hmm - thought you were ok if marked experimental - maybe I was chatting with someone else....
11:57 < peller> trutwijd_afk: yeah, I've been pretty lenient on that myself...
11:57 < peller> trutwijd_afk: weren't we going to get it reviewed by the tooltip owner? (guess that would be wildbill)
11:57 < trutwijd_afk> peller: bill helped me out with it, but I guess I wouldn't say he formally reviewed it or anything.  not sure the process
11:58 < peller> for dojox, there isn't much process.  just looking for some consensus
11:58 < peller> but you'd typically go through the subproject owner (and, in this case, if it has to do with existing code, the owner of that code)
11:58 < peller> dojox.widget is probably phiggins.
11:59 < trutwijd_afk> peller: it is
11:59 < trutwijd_afk> I'll make a comment on the trac about it - thx

[dante]

(In [20167]) adding in DynamicTooltip? courtesy trutwijd - small fixes/cleanups, removed a deprecated stub, added a doc stub indicating experimental dojox component. fixes #7027