Opened 11 years ago

Closed 8 years ago

Last modified 8 years ago

#7019 closed defect (fixed)

getBoundingBox appears broken for group objects

Reported by: guest Owned by: Eugene Lazutkin
Priority: high Milestone: 1.8
Component: DojoX GFX Version: 1.1.1
Keywords: dojox, gfx, getboundingbox, broken Cc:
Blocked By: Blocking:

Description

According to the documentation currently available, all shapes support the getBoundingBox method:

http://docs.google.com/View?docid=d764479_1hnb2tn

I'm trying to use the getBoundingBox method on a group object, and I can't get it to return any value other than null. For a representative example,go to:

http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/gfx/demos/lion.html

And use whatever console you have available to query the global "g" Group shape object:

g.getBoundingBox()

null

I've tried this in Firefox 3, Opera 9.5, and a recent Webkit nightly.

Attachments (2)

group.getBBox.patch (1.4 KB) - added by Jared Jurkiewicz 10 years ago.
Patch for issue. Reviewed and is clean and under CCLA
group.getBBox-test.html (19.9 KB) - added by Jared Jurkiewicz 10 years ago.
Test.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 11 years ago by bill

Milestone: tbd

mark all (open) tickets w/blank milestones to be "tbd"; their milestones need to be set to a version number or to "future"

comment:2 Changed 11 years ago by Eugene Lazutkin

Milestone: tbdfuture

Moving all open ticketd to the future.

comment:3 Changed 11 years ago by Eugene Lazutkin

Status: newassigned

comment:4 Changed 10 years ago by liyang

Patch and test case have been submitted to IBM internal issue tracker and IBM committer shall upload them here soon.

Changed 10 years ago by Jared Jurkiewicz

Attachment: group.getBBox.patch added

Patch for issue. Reviewed and is clean and under CCLA

Changed 10 years ago by Jared Jurkiewicz

Attachment: group.getBBox-test.html added

Test.

comment:5 Changed 10 years ago by Jared Jurkiewicz

Tested the patch on IE8, FF, Chrome

comment:6 Changed 8 years ago by Patrick Ruzand

Resolution: fixed
Status: assignedclosed

In [27449]:

fixes #7019, fix Group.getBoundingBox impl. !strict

comment:7 Changed 8 years ago by Patrick Ruzand

dojox/gfx/fx.js should not have been part of the 27449 rev. commit reverted for fx.js

comment:8 Changed 8 years ago by bill

Milestone: future1.8

comment:9 Changed 8 years ago by bill

[27550] rolls back the dojox/gfx/fx.js part of [27449].

comment:10 Changed 8 years ago by Patrick Ruzand

In [28625]:

fix missing silverlight impl of Group.getBoundingBox, refs #7019 !strict

Note: See TracTickets for help on using tickets.