Opened 13 years ago
Closed 8 years ago
#7018 closed defect (wontfix)
[dojox] FlickrRestStore regression or SlideShow onLoad issue in IE7
Reported by: | guest | Owned by: | dante |
---|---|---|---|
Priority: | low | Milestone: | future |
Component: | Dojox | Version: | 1.1.1 |
Keywords: | image slideshow internet explorer needsreview | Cc: | |
Blocked By: | Blocking: |
Description
Only the controls are visible, not the images.
Check the Dojo Campus example: http://dojocampus.org/explorer/#Dojox_Image_SlideShow_Basic
In Firefox it is fine.
I have marked this as critical as this problems means the slideshow (and probably lightbox too) unusable on any production site.
Attachments (1)
Change History (12)
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
Milestone: | → 1.2 |
---|---|
Owner: | changed from Adam Peller to dante |
Priority: | highest → normal |
severity: | critical → normal |
I'm seeing an error in IE6 in an animation onEnd, but everything seems to be working here:
http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/image/tests/
The explorer isn't really fit for a regression test, but yes, there is definitely something wrong happening there.
comment:3 Changed 13 years ago by
Thanks for the link Dante - it would look like the nightly code has partially resolved this problem. I'm going to give that a try.
comment:4 Changed 13 years ago by
(In [14099]) refs #7018 - at first it seemed a regression in dojo.string.substitute, which fails if the value passed is undefined. i suspect this is a regression in FlickrRestStore?, as it only affects the SlideShow?'s using that. onBegin seems to fire too often, and in the case of FlickrStore? is not passing the count as it was before. Adding a workaround to slurp items.length onComplete and adding a sanity check to the maxPhotos var in the string.substitute() call in _setTitle fixes any errors seen, but this is definately a regression in one of those two places. !strict also minor style cleanups across the board.
also exposes some jankyness -- currently nightly displays same issue though. in IE7, the overall widget isn't being sized if the image is in cache (it seems) but could be related to mis-firing of FlickrRest? Store. Going to pass to Bryan to look into FlickrRestStore?, but pass back if it's an image issue vs a store-event-firing issue.
comment:5 Changed 13 years ago by
Owner: | changed from dante to Bryan Forbes |
---|---|
Summary: | Slideshow doesn't load at all in IE6 or IE7 → [dojox] FlickrRestStore regression or SlideShow onLoad issue in IE7 |
comment:6 Changed 13 years ago by
Created a separate ticket just to track the issue of onBegin passing the wrong value - http://bugs.dojotoolkit.org/ticket/7117
Shane
comment:7 Changed 13 years ago by
Owner: | changed from Bryan Forbes to dante |
---|
I've traced this down to a SlideShow? issue. Basically, it's fetching things too many times and I'm not sure why. Somehow, the "showIt" call in the onComplete of setDataStore is triggering another fetch of all the data. I've tested the store and a normal fetch does not trigger multiple onBegins. Passing this back to Peter to figure out what's going wrong.
Changed 12 years ago by
Attachment: | SlideShow_height.patch added |
---|
Patch to fix this issue. The height of the widget was being determined before the first image had loaded. The solution is to wait for it to load.
comment:8 Changed 12 years ago by
Milestone: | 1.2 → 1.3 |
---|
this patch doesn't look like it should work? unless that callback is intentionally scoped later on, but not seeming so ... need more time to review.
comment:9 Changed 12 years ago by
Milestone: | 1.3 → future |
---|
comment:10 Changed 9 years ago by
Keywords: | needsreview added |
---|---|
Priority: | high → low |
i'm trying to identify stale tickets. if there is a need to keep this ticket open, please replace the "needsreview" keyword with "reviewed". if there is no need to keep this ticket open then please close it.
comment:11 Changed 8 years ago by
Resolution: | → wontfix |
---|---|
Status: | new → closed |
Given the decline of IE7, probably this won't be fixed.
See forum thread for confirmation:
http://dojotoolkit.org/forum/dojox-dojox/dojox-support/slideshow-behaves-very-differently-ff-and-ie