[dojox] FlickrRestStore regression or SlideShow onLoad issue in IE7

[guest]

Only the controls are visible, not the images.

Check the Dojo Campus example: ​http://dojocampus.org/explorer/#Dojox_Image_SlideShow_Basic

In Firefox it is fine.

I have marked this as critical as this problems means the slideshow (and probably lightbox too) unusable on any production site.

[guest]

See forum thread for confirmation:

http://dojotoolkit.org/forum/dojox-dojox/dojox-support/slideshow-behaves-very-differently-ff-and-ie

[dante]

I'm seeing an error in IE6 in an animation onEnd, but everything seems to be working here:

​http://archive.dojotoolkit.org/nightly/dojotoolkit/dojox/image/tests/

The explorer isn't really fit for a regression test, but yes, there is definitely something wrong happening there.

[guest]

Thanks for the link Dante - it would look like the nightly code has partially resolved this problem. I'm going to give that a try.

[dante]

(In [14099]) refs #7018 - at first it seemed a regression in dojo.string.substitute, which fails if the value passed is undefined. i suspect this is a regression in FlickrRestStore?, as it only affects the SlideShow?'s using that. onBegin seems to fire too often, and in the case of FlickrStore? is not passing the count as it was before. Adding a workaround to slurp items.length onComplete and adding a sanity check to the maxPhotos var in the string.substitute() call in _setTitle fixes any errors seen, but this is definately a regression in one of those two places. !strict also minor style cleanups across the board.

also exposes some jankyness -- currently nightly displays same issue though. in IE7, the overall widget isn't being sized if the image is in cache (it seems) but could be related to mis-firing of FlickrRest? Store. Going to pass to Bryan to look into FlickrRestStore?, but pass back if it's an image issue vs a store-event-firing issue.

[Shane O'Sullivan]

Created a separate ticket just to track the issue of onBegin passing the wrong value - ​http://bugs.dojotoolkit.org/ticket/7117

Shane

[Bryan Forbes]

I've traced this down to a SlideShow? issue. Basically, it's fetching things too many times and I'm not sure why. Somehow, the "showIt" call in the onComplete of setDataStore is triggering another fetch of all the data. I've tested the store and a normal fetch does not trigger multiple onBegins. Passing this back to Peter to figure out what's going wrong.

[Shane O'Sullivan]

Patch to fix this issue. The height of the widget was being determined before the first image had loaded. The solution is to wait for it to load.

[dante]

this patch doesn't look like it should work? unless that callback is intentionally scoped later on, but not seeming so ... need more time to review.

[ben hockey]

i'm trying to identify stale tickets. if there is a need to keep this ticket open, please replace the "needsreview" keyword with "reviewed". if there is no need to keep this ticket open then please close it.

[bill]

Given the decline of IE7, probably this won't be fixed.