Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#7003 closed defect (fixed)

storage_dialog.swf missing from source & release distributions

Reported by: guest Owned by: bradneuberg
Priority: high Milestone: 1.2
Component: Storage/Flash Version: 1.1.1
Keywords: Cc: mpirnat@…, James Burke
Blocked By: Blocking:

Description

When dojox.storage's Storage.swf needs to expand the allocated size of the Flash cookie, it wants to load up storage_dialog.swf. Unfortunately, in both the release and source distributions, only storage_dialog.fla exists; it needs to be compiled down to a .swf for distribution.

It is probably sufficient to copy over the storage_dialog.swf from the 0.4x tree since the .fla appears not to have changed at all (it MD5s the same for me in 0.4.1 and 1.1.1).

Further, from looking at Storage.as, it seems to expect the location of storage_dialog.swf to be in the same directory that dojo.baseUrl points to... Which would mean littering up the base dojo directory with dojox.storage-specific stuff. Some amount of fiddling with what dojox.flash passes to the Flash object (in the baseUrl parameter in dojox.flash._base) may be beneficial to keep things clean.

-- mpirnat (at) ag (dot) com

Change History (5)

comment:1 Changed 11 years ago by dylan

Cc: James Burke added
Milestone: tbd

Seems important enough and easy enough to address now. Can this be added to the build system James?

comment:2 Changed 11 years ago by James Burke

I could add the old .swf to the new tree, but it sounds like some other things need to change in dojox.flash._base for this to work, namely where it looks to find the module. I would feel more comfortable having bradneuberg make those changes.

I also feel like there were some flash vulnerabilities (with ExternalInterface??) that were patched if you compile with a very recent flash compiler. It would be good to sort that out, and if there is some tool we can use in the build system to compile the fla directly.

So would like more input from bradneuberg before proceeding.

comment:3 Changed 11 years ago by Brad Neuberg

Resolution: fixed
Status: newclosed

Unfortunately, this can't be automated in the Dojo build system. It is the one piece of Dojo Storage that requires the Flash IDE, since you can't do what it needs to have done from ActionScript?. I have loaded the storage_dialog.fla file into Flash Pro 2008, modified it to work with the Flash refactoring I did about 6 months ago (I accidentally missed this file), and recompiled it with the newest compiler to avoid the ExternalInterface? vulnerabilities James mentioned. I've confirmed everything works. Closing bug as FIXED.

comment:4 Changed 11 years ago by Brad Neuberg

(In [14592]) Fixes #7003

comment:5 Changed 11 years ago by bill

Milestone: tbd1.2
Note: See TracTickets for help on using tickets.