Opened 11 years ago

Closed 11 years ago

#6998 closed defect (fixed)

[dojox] cometd style guidelines adherance

Reported by: dante Owned by: dante
Priority: high Milestone: 1.2
Component: DojoX Cometd Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

There are many many minor nuances about dojox.cometd._base that do not follow Dojo's style guidelines.

Also, In the spirit of keeping everything on the wire as small as possible, we should minimize repeated patterns where possible and/or define a design pattern for default optimization within Dojo, which is out of the scope of this ticket, though is demonstrated some in the patch. (console.* is guaranteed, no need to check ... mixin(this,{}) vs "this" x 20 ... )

Attachments (1)

cleanup.patch​ (12.8 KB) - added by dante 11 years ago.
mostly style cleanups …

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by dante

Attachment: cleanup.patch​ added

mostly style cleanups ...

comment:1 Changed 11 years ago by dante

Status: new → assigned

captain obvious says: thank god for unit tests. patch is bad, but unit test prove it. commit coming, including basic unit testing for cometd.

dojo.mixin(this,{ foo = "bar" }); will not work, anywhere.

comment:2 Changed 11 years ago by dante

Resolution: → fixed
Status: assigned → closed

(In [14067]) fixes #6998 - adds _minimal_ unit test to cometd core, and applies style cleanups.

Note: See TracTickets for help on using tickets.