Opened 13 years ago
Closed 13 years ago
#6998 closed defect (fixed)
[dojox] cometd style guidelines adherance
Reported by: | dante | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | DojoX Cometd | Version: | 1.1.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
There are many many minor nuances about dojox.cometd._base that do not follow Dojo's style guidelines.
Also, In the spirit of keeping everything on the wire as small as possible, we should minimize repeated patterns where possible and/or define a design pattern for default optimization within Dojo, which is out of the scope of this ticket, though is demonstrated some in the patch. (console.* is guaranteed, no need to check ... mixin(this,{}) vs "this" x 20 ... )
Attachments (1)
Change History (3)
Changed 13 years ago by
Attachment: | cleanup.patch added |
---|
comment:1 Changed 13 years ago by
Status: | new → assigned |
---|
captain obvious says: thank god for unit tests. patch is bad, but unit test prove it. commit coming, including basic unit testing for cometd.
dojo.mixin(this,{ foo = "bar" });
will not work, anywhere.
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
mostly style cleanups ...