#6958 closed defect (fixed)
[cla][patch] dojox.image.SlideShow fixed exception when no image title is set
Reported by: | guest | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Dojox | Version: | 1.1.1 |
Keywords: | image slideshow | Cc: | |
Blocked By: | Blocking: |
Description
this ticket was created by: Norman "matsuri" Wenk
when there is no image title set, the "onEnd" event handler in SlideShow?.showImage() throws following exception:
exception in animation handler for: onEndbootstrap.js (line 522) TypeError?: value has no properties message=value has no properties
the "onEnd" handler calls:
_this.setTitle(title)
...which calls:
dojo.string.substitute(this.titleTemplate, { title: title, current: + this.imageIndex, total: this.maxPhotos});
dojo.string.substitute seems to need a string passed... and because title is no string when it isnt set it throws an exception
my patch ensures title to be a string.. at least an empty one if not set
Attachments (1)
Change History (4)
Changed 13 years ago by
Attachment: | dojox.image.SlideShow.patch added |
---|
comment:1 Changed 13 years ago by
Owner: | changed from Adam Peller to dante |
---|
comment:2 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 13 years ago by
Milestone: | → 1.2 |
---|
Hi Norman, by the way you can (and should) write your name in the "Reporter" field. Or email, so that you can get notification of changes to the ticket.
I suggest