Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6958 closed defect (fixed)

[cla][patch] dojox.image.SlideShow fixed exception when no image title is set

Reported by: guest Owned by: dante
Priority: high Milestone: 1.2
Component: Dojox Version: 1.1.1
Keywords: image slideshow Cc:
Blocked By: Blocking:

Description

this ticket was created by: Norman "matsuri" Wenk

when there is no image title set, the "onEnd" event handler in SlideShow?.showImage() throws following exception:

exception in animation handler for: onEndbootstrap.js (line 522) TypeError?: value has no properties message=value has no properties

the "onEnd" handler calls:

_this.setTitle(title)

...which calls:

dojo.string.substitute(this.titleTemplate, { title: title, current: + this.imageIndex, total: this.maxPhotos});

dojo.string.substitute seems to need a string passed... and because title is no string when it isnt set it throws an exception

my patch ensures title to be a string.. at least an empty one if not set

Attachments (1)

dojox.image.SlideShow.patch (521 bytes) - added by guest 11 years ago.

Download all attachments as: .zip

Change History (4)

Changed 11 years ago by guest

Attachment: dojox.image.SlideShow.patch added

comment:1 Changed 11 years ago by Adam Peller

Owner: changed from Adam Peller to dante

I suggest

var title = img.getAttribute("title") || "";

comment:2 Changed 11 years ago by dante

Resolution: fixed
Status: newclosed

(In [13995]) fixes #6958 - thanks matsuri for finding. using peller's suggestion (no need for two getAttribute calls)

comment:3 Changed 11 years ago by bill

Milestone: 1.2

Hi Norman, by the way you can (and should) write your name in the "Reporter" field. Or email, so that you can get notification of changes to the ticket.

Note: See TracTickets for help on using tickets.