Opened 12 years ago

Closed 11 years ago

#6941 closed defect (fixed)

wipeIn()/wipeOut() leave overflow:hidden on nodes

Reported by: bill Owned by: bill
Priority: high Milestone: 1.2
Component: fx Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

The wipeIn() and wipeOut() effect sets overflow: hidden during the effect so that there's no scrollbar shown. And it doesn't erase that style setting (or rather, revert it to whatever the original setting was) when the effect ends.

Normally this isn't an issue, since when the wipeIn() animation finishes the node is it's natural height and thus there is no vertical overflow... the problem is horizontal overflow. If the node has horizontal overflow (and thus needs a horizontal scrollbar), that horizontal overflow is getting hidden.

For test case see #6940

Change History (4)

comment:1 Changed 12 years ago by bill

Resolution: fixed
Status: newclosed

(In [13981]) Fixes #6940: tree items cutoff at right for tree wrapped in narrow div Fixes #6941: dojo.wipeIn() leaves overflow:hidden on nodes

comment:2 Changed 11 years ago by bill

FYI you can patch this against an old version of dojo by adding this code after your dojo.require() statements:

var wi = dojo.fx.wipeIn, wo = dojo.fx.wipeOut;
dojo.fx.wipeIn = function(args){
	var anim = wi(args);
	dojo.connect(anim, "onEnd", function(){
		args.node.style.overflow = "";
	});
	return anim;
}
dojo.fx.wipeOut = function(args){
	var anim = wo(args);
	dojo.connect(anim, "onEnd", function(){
		args.node.style.overflow = "";
	});
	return anim;
}

comment:3 Changed 11 years ago by bill

Description: modified (diff)
Resolution: fixed
Status: closedreopened
Summary: wipeIn() leaves overflow:hidden on nodeswipeIn()/wipeOut() leave overflow:hidden on nodes

Oops, I forgot about the equivalent problem w/wipeOut().

comment:4 Changed 11 years ago by bill

Resolution: fixed
Status: reopenedclosed

(In [14073]) Fix wipeOut() to also leave the overflow setting as it was before the effect started. Fixes #6941.

Note: See TracTickets for help on using tickets.