[patch][cla] ComboBox form name missing

[cfranks@…]

When I create a ComboBox widget, the input field's name isn't being set for the submitted form.

This is the code I'm using to create the ComboBox:

<input class="dojo_autocomplete_textfield" id="widget_name" name="name" type="text" />
<script type="text/javascript">
	dojo.require("dojo.widget.*");
	dojo.require("dojo.widget.ComboBox");
	dojo.widget.createWidget(
		"ComboBox",
		{mode: "remote", 
		dataUrl: "dojo.pl?name_search=%{searchString}", 
		formInputName: "name"},
		dojo.byId("widget_name")
);

If I type 'foo' into the ComboBox, and submit the form, I get the values:

'' => 'foo'
'_selected' => 'foo'

Looking at the code for html/ComboBox.js, I can see that the variable "formInputName" is never used. It also doesn't seem to be successfully getting the name from the input tag attribute.

Also, is it really necessary for the ${name}_selected value to be sent in the form?

I'm running dojo svn version 3932

[cfranks@…]

patch for src/widget/html/ComboBox.js

[cfranks@…]

Looking at the source, I've realised that I should have been passing the option "name" rather than "formInputName".

The patch I've just attached deals with 2 issues.

First it removes the reference to the "this.formInputName" value which is never used.

Secondly, if the "name" option isn't passed to the widget constructor, fillInTemplate instead tries to retreive the name from the source fragment.

[dylan]

we need a CLA on file to accept patches. Can you fax or email one in so I can apply this patch?

[dylan]

(In [5695]) fixes #692, ComboBox? form name missing, thanks for the patch

[(none)]

Milestone 0.4 deleted