Opened 11 years ago

Closed 4 years ago

#6901 closed defect (patchwelcome)

console.debug fails when dealing with XML node lists in IE

Reported by: James Burke Owned by: Bryan Forbes
Priority: low Milestone: 1.13
Component: IO Version: 1.1.1
Keywords: needsreview Cc:
Blocked By: Blocking:

Description

See attached use case. Probably affects other console.* methods. Basic issue:

dojo.xhrGet() for an XML file. Do a nodeList = response.getElementsByTagName("tagname") on the returned XML document. Try to use console.debug(nodeList), and an error happens.

It happens both in the djConfig.isDebug = true or false. An initial debug in a isDebug = false case led to bootstrap.js, around line 99 where this call happens:

console.log(a.join(" "));

Something about the array join call, when it tries to do a toString maybe on the XML node list, that has problems in IE?

Anyway, not sure how to get around this. I am not sure if we can detect a "type" of object in this case for IE and then either skip the object or use a string placeholder for it.

Note that doing an alert() on the node list gives [object]. Not sure the difference between that and what happens with the array join.

Attachments (2)

iedebug.html (1.1 KB) - added by James Burke 11 years ago.
Test HTML page. Place in dojo/tests/_base folder
iedebug.xml (268 bytes) - added by James Burke 11 years ago.
XML file for the HTML test page to fetch. Place in dojo/tests/_base

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by James Burke

Attachment: iedebug.html added

Test HTML page. Place in dojo/tests/_base folder

Changed 11 years ago by James Burke

Attachment: iedebug.xml added

XML file for the HTML test page to fetch. Place in dojo/tests/_base

comment:1 Changed 11 years ago by dylan

Milestone: future

comment:2 Changed 8 years ago by Chris Mitchell

Owner: anonymous deleted

comment:3 Changed 8 years ago by ben hockey

Keywords: needsreview added
Priority: highlow

comment:4 Changed 7 years ago by dylan

Component: CoreIO
Milestone: future1.9
Owner: set to Bryan Forbes
Status: newassigned

Bryan, is this an issue with dojo/request? If not, we can resolve as fixed. If so, we should probably mark as wontfix since we won't support older IE for Dojo 2.0 (unless it's also an issue with IE 9 or 10)

comment:5 Changed 6 years ago by bill

Milestone: 1.91.10

Bumping this ticket since we are past the deadline for the 1.9RC. The fix can be put into 1.9.1 too, if desired.

comment:6 Changed 5 years ago by dylan

Milestone: 1.101.11

comment:7 Changed 4 years ago by dylan

Milestone: 1.111.12

comment:8 Changed 4 years ago by dylan

Resolution: patchwelcome
Status: assignedclosed

Closing as patchwelcome. If this is still relevant in modern IE or Edge, and someone wants to review and verify this for either Dojo 1.x's dojo/request or Dojo 2's dojo-core/request, we would be interested.

Note: See TracTickets for help on using tickets.