Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#685 closed defect (fixed)

[patch] Fixes for data/Item.js

Reported by: eugene@… Owned by: skinner
Priority: high Milestone:
Component: General Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

Two fixes are in:

  1. dojo.data.Item.compare - apparently otherItem was lost in renaming frenzy. Renamed to itemTwo, which, I believe, is the intended name.
  2. dojo.data.Item.prototype.hasAttribute did some fancy dance with a loop. I simplified it to make it shorter, more explicit, and more efficient.

Attachments (1)

dojo.data.Item.patch​ (1.0 KB) - added by eugene@… 13 years ago.

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by eugene@…

Attachment: dojo.data.Item.patch​ added

comment:1 Changed 13 years ago by skinner

Milestone: → 0.4
Owner: changed from anonymous to skinner
Status: new → assigned

Thanks for the patch Eugene -- I'll apply it as soon as I have a chance to get back to working on code.

comment:2 Changed 13 years ago by skinner

Resolution: → fixed
Status: assigned → closed

fixed in rev 4678

comment:3 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.