Opened 11 years ago
Closed 11 years ago
#6846 closed defect (fixed)
"inherited" method doesn't support patching
| Reported by: | sjmiles | Owned by: | sjmiles |
|---|---|---|---|
| Priority: | high | Milestone: | 1.2 |
| Component: | Core | Version: | 1.1.1 |
| Keywords: | Cc: | Nathan Toone | |
| Blocked By: | Blocking: |
Description
Because "inherited" uses searching to match methods to prototypes, you cannot monkey-patch a method uses inherited.
Attachments (1)
Change History (7)
comment:1 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:2 Changed 11 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:3 Changed 11 years ago by
| Cc: | nathan added |
|---|
This change seems to break classes that have a preamble specified.
Changed 11 years ago by
| Attachment: | declare.diff added |
|---|
Uncommenting this block seems to address the issue. I don't know why it was commented out in the first place, or what repercussions there may be.
comment:4 Changed 11 years ago by
Ok, sorry about that. I replaced that code as suggested in r13857.
Will have to look into why this was not caught by the unit test.
comment:5 Changed 11 years ago by
| Cc: | Nathan Toone added; nathan removed |
|---|
comment:6 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Believe this is working now. Any new problems should probably get fresh tickets.
Note: See
TracTickets for help on using
tickets.
(In [13843]) Extend "inherited" method in declare to use memoized prototype information when available instead of searching. Should improve speed of "inherited" and also fixes #6846. !strict