#6842 closed enhancement (fixed)
[dijit.layout] Consider deprecating AccordionPane
Reported by: | dante | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.3 |
Component: | Dijit | Version: | 1.1.1 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
It seems odd we have this intermediary AccordionPane? (a templated ContentPane?) as a child of AccordionContainer? exclusively. Following in line with BorderContainer?, consider moving the templating logic into AccContainer?, and allow for any layout widget to be a child of the Container. This would allow you to more easily move children around from Tab->Accordion->Border->etc using the .addChild and .removeChild API. Currently, you need to create an AccPane?, add it to the AccContainer?, then setContent the domNode or the Child you want. It's probably possible to pull off with no "real" API change.
If all goes well, the proposed shim would be:
dojo.declare("dijit.layout.AccordionPane", dijit.layout.ContentPane, { constructor: function(){ dojo.deprecated(); } });
Change History (9)
comment:1 Changed 13 years ago by
Milestone: | 1.4 → 1.3 |
---|
comment:2 Changed 12 years ago by
Milestone: | 1.3 → 1.4 |
---|
comment:3 Changed 12 years ago by
Milestone: | 1.4 → 1.3 |
---|---|
Owner: | changed from dante to bill |
Status: | new → assigned |
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Refactored in [15912]
comment:7 Changed 12 years ago by
comment:8 Changed 12 years ago by
(In [15978]) Test and fix addChild() for ContentPane? and AccordionContainer?. Refs #6842, #7819. !strict.
comment:9 Changed 12 years ago by
(In [16070]) Use ContentPane? not deprecated AccordionPane?. Also, for the ContentPane? that embeds a TitlePane?, should use the default 5px padding so there's no double-border effect. Refs #6842.
bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4