Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#6842 closed enhancement (fixed)

[dijit.layout] Consider deprecating AccordionPane

Reported by: dante Owned by: bill
Priority: high Milestone: 1.3
Component: Dijit Version: 1.1.1
Keywords: Cc:
Blocked By: Blocking:

Description

It seems odd we have this intermediary AccordionPane? (a templated ContentPane?) as a child of AccordionContainer? exclusively. Following in line with BorderContainer?, consider moving the templating logic into AccContainer?, and allow for any layout widget to be a child of the Container. This would allow you to more easily move children around from Tab->Accordion->Border->etc using the .addChild and .removeChild API. Currently, you need to create an AccPane?, add it to the AccContainer?, then setContent the domNode or the Child you want. It's probably possible to pull off with no "real" API change.

If all goes well, the proposed shim would be:

dojo.declare("dijit.layout.AccordionPane", dijit.layout.ContentPane, {
   constructor: function(){ dojo.deprecated(); }
});

Change History (9)

comment:1 Changed 11 years ago by dante

Milestone: 1.41.3

comment:2 Changed 11 years ago by bill

Milestone: 1.31.4

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

comment:3 Changed 10 years ago by bill

Milestone: 1.41.3
Owner: changed from dante to bill
Status: newassigned

comment:4 Changed 10 years ago by bill

Resolution: fixed
Status: assignedclosed

Refactored in [15912]

comment:5 Changed 10 years ago by bill

comment:6 Changed 10 years ago by bill

And [15924].

comment:7 Changed 10 years ago by bill

(In [15960]) Fix typo from [15912] causing closed then opened pane to have no scrollbar. Refs #4016, #6842 !strict

comment:8 Changed 10 years ago by bill

(In [15978]) Test and fix addChild() for ContentPane? and AccordionContainer?. Refs #6842, #7819. !strict.

comment:9 Changed 10 years ago by bill

(In [16070]) Use ContentPane? not deprecated AccordionPane?. Also, for the ContentPane? that embeds a TitlePane?, should use the default 5px padding so there's no double-border effect. Refs #6842.

Note: See TracTickets for help on using tickets.