DnD dosnt work properly when constrained to a node (patch attached - CLA is on file - file dnd/HtmlDragAndDrop.js).

[elricho66@…]

getConstraints assumed the constraining node was positioned at 0,0 ... When its not then the constraining box is not positioned correctly .. Here's a patch.

146d145
<                       screenPos = dojo.style.getAbsolutePosition(this.constrainingContainer, true);
150,153c149,152
<                       minX: padLeft + screenPos.x,
<                       minY: padTop + screenPos.y,
<                       maxX: padLeft+width - dojo.style.getOuterWidth(this.domNode) + screenPos.x,
<                       maxY: padTop+height - dojo.style.getOuterHeight(this.domNode) + screenPos.y
---
>                       minX: padLeft,
>                       minY: padTop,
>                       maxX: padLeft+width - dojo.style.getOuterWidth(this.domNode),
>                       maxY: padTop+height - dojo.style.getOuterHeight(this.domNode)

[bill]

Thanks for the patch. Please attach patches rather then putting them inline. Otherwise the formatting gets messed up.

Also, shouldn't the calculation for maxX/maxY reference padRight, padBottom?

[elricho66@…]

Test cases for bug fixes

[elricho66@…]

Err .. ignore that second patch bill .. sorry bout that :-)

padRight is calculated by padLeft + contentWidth .... so its taken care of .. Attached is a diff (against the original - not my first diff ..) & a test case for the nightly build ..

Cheers Richard

[bill]

Richard - left and right padding are not necessarily the same. You need to look at the value of padding-right, not just padding-left. (Similary for padding-bottom)

[bill]

Fixed in [4166]

[(none)]

Milestone 0.3.1 deleted