dojox.grid.DataGrid: deleting an item before scrolling down results in missing data

[Nathan Toone]

Setup:

1 - A DataGrid? with lots of data (more data than exists in the rowsPerPage) 2 - Delete an element from the top part of the data before scrolling 3 - Scroll to bottom

Where the page break happens (and the fetch for the next set of data occurs), there is a missing element. I don't know if this is a datastore issue or a grid issue. (I'm using ItemFileWriteStore? in my test)

[Nathan Toone]

I have not seen this recently, and as I was the one who opened it, I will now close it.

[Marcin Gołębski]

When a row is deleted, all rest rows are shifted down, and migrate from page to page. If some page is not loaded yet empty rows can migrate to initialized pages without refreshing. It causes empty rows in some pages

[Nathan Toone]

This patch is very close - but now, whenever you scroll to the next page, it takes MUCH longer to load the subsequent pages. For an example, look at the test_edit.html test case, delete the first row, and then scroll down to about row 25. Before applying the patch, the bug exists (row 25 is all "...") - after applying the patch, it works...but takes much longer to load rows 26-50 (and I get a UI hang in FF3.5 when it happens).

[Marcin Gołębski]

Replying to toonetown:

Before applying the patch, the bug exists (row 25 is all "...") - after applying the patch, it works...but takes much longer to load rows 26-50 (and I get a UI hang in FF3.5 when it happens).

This can occure becouse the condision is to much general. The second patch will solve this problem.

[Marcin Gołębski]

better solution

[Nathan Toone]

I'm still getting a much longer delay when rendering subsequent pages with the second patch as well...

[Marcin Gołębski]

Replying to toonetown:

I'm still getting a much longer delay when rendering subsequent pages with the second patch as well...

OK, now I understand where the problem is. I changed approach, I thing for proper one. Insted of checking which row is missing, I suggest reset loaded-page info each time the row is deleted, becouse this info is no longer consistent. After DataSource?-3.patch application test_edit.html runs fine for me.

[Marcin Gołębski]

best solution :)

[Nathan Toone]

Thank you very much for these patches! I will take a look at this last one tomorrow morning.

[Marcin Gołębski]

You are pretty fast :) Have a good night. Regards. Marcin

[Nathan Toone]

(In [20314]) Fixes #6818 !strict - clear out our indexes when we delete an item. Thanks for the patch!