Dialog: way to know when the show and hide animations have completed

[Ben Lowery]

Currently, show and hide are async operations due to the animated implementation and there is no way to know when show and hide have really completed.

Please modify show and hide to either take a callback which is called upon completion, or return either a dojo.Deferred whose callback is invoked upon completion (possibly passing the Dialog as an argument?) or return the _Animation that's driving show and hide(). I have no strong preference towards which api to expose.

[bill]

This was discussed on IRC last night. Note that although the animation object returns a Deferred, it's difficult to use because the animation object itself is reused (the next time you show the Dialog).

[bill]

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

[Karl Tiedt]

something like this should work...

[Karl Tiedt]

Its really trivial since all widgets have onHide/onShow already... and Dialog already has onHide called from its onEnd of _fadeOut animation... just added the same to _fadeIn animations onEnd...

[Karl Tiedt]

Live example at ​http://ktiedt.dojotoolkit.org/dojotoolkit/dijit/tests/test_Dialog.html

forgot to mention that

[bill]

Except that Dialog calls _onShow() at the beginning of the animation to trigger the href load.

[bill]

(In [23320]) Make Dialog.show() and Dialog.hide() return a dojo.Deferred that resolves when the animation is complete, fixes #6804 !strict.

[bill]

(In [23321]) Make Dialog.show() and Dialog.hide() return a dojo.Deferred that resolves when the animation is complete, fixes #6804 !strict.