#6804 closed defect (fixed)
Dialog: way to know when the show and hide animations have completed
Reported by: | Ben Lowery | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.6 |
Component: | Dijit | Version: | 1.1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Currently, show and hide are async operations due to the animated implementation and there is no way to know when show and hide have really completed.
Please modify show and hide to either take a callback which is called upon completion, or return either a dojo.Deferred whose callback is invoked upon completion (possibly passing the Dialog as an argument?) or return the _Animation that's driving show and hide(). I have no strong preference towards which api to expose.
Attachments (1)
Change History (9)
comment:1 Changed 13 years ago by
Component: | General → Dijit |
---|---|
Milestone: | → 1.4 |
Owner: | anonymous deleted |
Summary: | Allow client of dijit.Dialog to know when the show and hide animations have completed → Dialog: way to know when the show and hide animations have completed |
comment:2 Changed 12 years ago by
Milestone: | 1.4 → 1.5 |
---|
bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4
comment:3 Changed 11 years ago by
Milestone: | 1.5 → 1.6 |
---|
comment:4 Changed 10 years ago by
Its really trivial since all widgets have onHide/onShow already... and Dialog already has onHide called from its onEnd of _fadeOut animation... just added the same to _fadeIn animations onEnd...
comment:5 Changed 10 years ago by
Live example at http://ktiedt.dojotoolkit.org/dojotoolkit/dijit/tests/test_Dialog.html
forgot to mention that
comment:6 Changed 10 years ago by
Owner: | set to bill |
---|---|
Status: | new → assigned |
Except that Dialog calls _onShow() at the beginning of the animation to trigger the href load.
comment:7 Changed 10 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
This was discussed on IRC last night. Note that although the animation object returns a Deferred, it's difficult to use because the animation object itself is reused (the next time you show the Dialog).