Opened 13 years ago
Closed 12 years ago
#6781 closed enhancement (wontfix)
[patch][needs cla] BorderContainer: added showHideRegion feature
Reported by: | guest | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | future |
Component: | Dijit | Version: | 1.1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
Hi I added to BorderContainer? a feature to hide and show regions.
I hope that it can be included in BorderContainer? widget.
Giovanni Porcari (aka genro)
showHideRegion: function(region,visible){ var regionNode = this['_'+region] if (regionNode){ dojo.style(regionNode,'display',(visible? '':'none')); var splitterNode = this._splitters[region] if (splitterNode){ var tk=this._splitterThickness['_'+region] || this._splitterThickness[region] this._splitterThickness['_'+region]=tk dojo.style(splitterNode,'display',(visible? '':'none')); this._splitterThickness[region] =visible? tk : 0 } this.layout() } },
Attachments (2)
Change History (10)
Changed 13 years ago by
Attachment: | BorderContainer.js added |
---|
Changed 13 years ago by
Attachment: | test_BorderContainer_showHideRegion.html added |
---|
comment:1 Changed 13 years ago by
Summary: | Border Container added showHideRegion feature → [patch][needs cla] Border Container added showHideRegion feature |
---|
comment:2 Changed 13 years ago by
As Dylan said we need a CLA before looking at patches.
Note also that we have something similar in ExpandoPane.
I'm not quite sure what the advantage is of hiding/showing a pane rather than removing it from the BorderContainer and readding it? Perhaps it's a bit easier for the developer?
comment:3 Changed 13 years ago by
Owner: | set to dante |
---|
comment:4 Changed 13 years ago by
Summary: | [patch][needs cla] Border Container added showHideRegion feature → [patch][needs cla] BorderContainer: added showHideRegion feature |
---|
comment:5 Changed 13 years ago by
Milestone: | → tbd |
---|
mark all (open) tickets w/blank milestones to be "tbd"; their milestones need to be set to a version number or to "future"
comment:6 Changed 12 years ago by
Milestone: | tbd → 1.3 |
---|---|
Status: | new → assigned |
will close out if 1.3 comes and no CLA is submitted ... ExpandoPane? does this, and is almost a11y ready. Hopefully will be ready for proposing into dijit by 1.3 (expando)
comment:7 Changed 12 years ago by
Milestone: | 1.3 → 1.4 |
---|
bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4
comment:8 Changed 12 years ago by
Milestone: | 1.4 → future |
---|---|
Resolution: | → wontfix |
Status: | assigned → closed |
closing in favor of expando and lack of cla
Hi Giovanni, we require a CLA to accept patches... http://dojotoolkit.org/community and http://dojotoolkit.org/cla. Any chance you can send one over so we can look into this?