[patch][needs cla] BorderContainer: added showHideRegion feature

[guest]

Hi I added to BorderContainer? a feature to hide and show regions.

I hope that it can be included in BorderContainer? widget.

Giovanni Porcari (aka genro)

[email protected]…

    showHideRegion: function(region,visible){
        var regionNode = this['_'+region]
        if (regionNode){
            dojo.style(regionNode,'display',(visible? '':'none'));
            var splitterNode = this._splitters[region]
            if (splitterNode){
                var tk=this._splitterThickness['_'+region] || this._splitterThickness[region]
                this._splitterThickness['_'+region]=tk
                dojo.style(splitterNode,'display',(visible? '':'none'));
                this._splitterThickness[region] =visible? tk : 0
            }
            this.layout()
        }
    },

[dylan]

Hi Giovanni, we require a CLA to accept patches... http://dojotoolkit.org/community and http://dojotoolkit.org/cla. Any chance you can send one over so we can look into this?

[bill]

As Dylan said we need a CLA before looking at patches.

Note also that we have something similar in ​ExpandoPane.

I'm not quite sure what the advantage is of hiding/showing a pane rather than removing it from the BorderContainer and readding it? Perhaps it's a bit easier for the developer?

[bill]

mark all (open) tickets w/blank milestones to be "tbd"; their milestones need to be set to a version number or to "future"

[dante]

will close out if 1.3 comes and no CLA is submitted ... ExpandoPane? does this, and is almost a11y ready. Hopefully will be ready for proposing into dijit by 1.3 (expando)

[bill]

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

[dante]

closing in favor of expando and lack of cla