Opened 11 years ago

Closed 11 years ago

#6779 closed defect (fixed)

[dijit] AccordionPane doesn't respect refreshOnShow

Reported by: dante Owned by: bill
Priority: high Milestone: 1.2
Component: General Version: 1.1.0
Keywords: Cc:
Blocked By: Blocking:

Description

Setting refreshOnShow on an accordion pane doesn't do anything. The widgets are reparsed and remade on every view, causing "duplicate id" messages where they are meant to be prevented (by setting refeshOnShow=false) ... Will commit simple test case, and attach trivial patch to fix the issue.

It is so trivial and such an oversight I propose 1.1.2 if we do one, but marking 1.2 for now.

Attachments (1)

accordion.patch (2.0 KB) - added by dante 11 years ago.
one fix + minor style adjustments

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by dante

Attachment: accordion.patch added

one fix + minor style adjustments

comment:1 Changed 11 years ago by dante

(In [13757]) refs #6779 - test case illustrating b0rken refreshOnShow in accordion.

comment:2 Changed 11 years ago by dante

Resolution: fixed
Status: newclosed

(In [13763]) fixes #6779 - refreshOnShow support fixed in AccordionPane?. ContentPane? correctly checks refreshOnShow, and AccordionPane? forcing 'true' broke that. Minor style cleanups otherwise. !strict because it's easier.

Note: See TracTickets for help on using tickets.