Opened 13 years ago
Closed 5 years ago
#6774 closed defect (patchwelcome)
Possibly better handling of heights in dojo.fx.wipeIn
Reported by: | Owned by: | Bryan Forbes | |
---|---|---|---|
Priority: | high | Milestone: | 1.13 |
Component: | fx | Version: | 1.1.0 |
Keywords: | fx needsreview | Cc: | |
Blocked By: | Blocking: |
Description (last modified by )
When using dojo.fx.wipeIn the effect tends to "snap" at the end in our application. I tracked the problem down to a height = "auto" call when the effect ends. When I apply the following diff, it appears to fix the problem in FF3 and Safari 3 both Mac. My fix is just a quick hack, I assume that there might be a better way to handle this.
Here is the diff:
Index: public/javascripts/dojo/dojo/fx.js =================================================================== --- public/javascripts/dojo/dojo/fx.js (revision 5771) +++ public/javascripts/dojo/dojo/fx.js (working copy) @@ -336,10 +336,6 @@ } }, args)); - dojo.connect(anim, "onEnd", function(){ - s.height = "auto"; - }); - return anim; // dojo._Animation }
Change History (5)
comment:1 Changed 13 years ago by
Cc: | [email protected]… removed |
---|---|
Description: | modified (diff) |
Reporter: | changed from guest to [email protected]… |
comment:2 Changed 13 years ago by
Milestone: | → tbd |
---|
mark all (open) tickets w/blank milestones to be "tbd"; their milestones need to be set to a version number or to "future"
comment:3 Changed 12 years ago by
Milestone: | tbd → future |
---|
comment:4 Changed 9 years ago by
Keywords: | needsreview added |
---|
comment:5 Changed 5 years ago by
Milestone: | future → 1.12 |
---|---|
Resolution: | → patchwelcome |
Status: | new → closed |
Given the lack of interest over the past 5+ years, I'm closing as patchwelcome. Please re-open if you want to create a pull request.
Note: See
TracTickets for help on using
tickets.
I think we intentionally set height=auto because (for example) 10 minutes after you wipeIn() a <div>, it's height may change, like for example if the user hits Ctrl+ to increase the font-size, or maybe the content inside the <div> changes, like a setContent() call on a ContentPane.
Of course in many cases the thing being wiped in will never change size (ex: an image).
I wonder setting height=auto causes the jumpy effect in the first place though. Presumably it isn't changing the height... maybe something with margin or borders? Do you have a simple test case?