Opened 11 years ago

Closed 11 years ago

#6764 closed defect (fixed)

BorderContainer support padding

Reported by: nonken Owned by: Adam Peller
Priority: high Milestone: 1.2
Component: Dijit - LnF Version: 1.1.0
Keywords: BorderContainer, Padding Cc: bill, nonken, Sam Foster
Blocked By: Blocking:

Description (last modified by nonken)

To create a more solid L&F each bordercontainer which is using splitters as well should have a default padding with the bgcolor of the splitter. Using this padding the splitters will not end up in nothing but the BorderContainer?'s children will be embedded in the BorderContainer? resulting in an improved L&F. For BC elements not having a splitter you should be able to set that padding to 0

Attachments (2)

BCpadding.png​ (104.3 KB) - added by nonken 11 years ago.
This BorderContainer? has a "padding" note the browser does not have a correct window size
BCnopadding.png​ (105.9 KB) - added by nonken 11 years ago.
Current BC style

Download all attachments as: .zip

Change History (13)

comment:1 Changed 11 years ago by nonken

Cc: Sam Foster added

Changed 11 years ago by nonken

Attachment: BCpadding.png​ added

This BorderContainer? has a "padding" note the browser does not have a correct window size

Changed 11 years ago by nonken

Attachment: BCnopadding.png​ added

Current BC style

comment:2 Changed 11 years ago by nonken

Description: modified (diff)

comment:3 Changed 11 years ago by Adam Peller

Resolution: → fixed
Status: new → closed

(In [13743]) Compute layout with padding. Fixes #6764 !strict

comment:4 Changed 11 years ago by nonken

(In [13928]) removed default border on BorderContainer?, refs #6764

comment:5 Changed 11 years ago by nonken

(In [13930]) set width/height to 100%, refs #6764

comment:6 Changed 11 years ago by nonken

(In [13933]) fixed so BorderContainer? supports 100% width/height + padding, refs #6764 !strict

comment:7 Changed 11 years ago by nonken

(In [13948]) fixed themeTester layout, Refs #6764

comment:8 Changed 11 years ago by bill

(In [14414]) Fix non-portable code for padding calculations, refs #6764 !strict. This fixes mail demo editor layout problems in safari, refs #7096, #7097.

comment:9 Changed 11 years ago by bill

(In [14419]) Oops, forgot node argument to _toPixelValue(). refs #6764 !strict.

comment:10 Changed 11 years ago by nonken

Resolution: fixed
Status: closed → reopened

Now BC doesn't have the padding anymore on bottom and left. check themeTester.html to see. Probably some regression

comment:11 Changed 11 years ago by bill

Milestone: → 1.2
Resolution: → fixed
Status: reopened → closed

Yah, I broke this but then fixed it above in [14419].

Note: See TracTickets for help on using tickets.