FilteringSelect: way of adding new items

[guest]

I defined a FilteringSelect dijit in html (using option tags instead of a datastore.). I've discovered that it is not possible to add a new item to the filtering select after it has been parsed.

Something like dijit.byId('id').addItem(name, value) really needs to be added.

At the very least there needs to be a way to add an item to the underlying default datastore.

[Adam Peller]

see #6029

[bill]

This boils down to implementing dojo.data.api.Write in dijit.form._ComboBoxDataStore (which would add requested feature for both ComboBox and FilteringSelect.

[bill]

bumping 1.4 tickets to 1.5, and most 1.3 tickets to 1.4

[Nathan Toone]

Unassigning my tickets.

[haysmark]

I'll look at this. We have to implement:

• newItem
• deleteItem
• setValue
• setValues
• unsetAttribute
• save
• revert
• isDirty

The items are option tags, so newItem would expect at least the attributes "value" and "innerHTML". newItem would also mark new items as dirty. setValues would throw "feature not implemented." save would mark everything as clean and call both _saveEverything and _saveCustom like ItemFileWriteStore?. revert would throw out dirty items. isDirty would check for the dirt attribute. I think we can get away with a sufficiently small implementation that it won't severely impact the performance of existing users.

[haysmark]

Are we going to have the new data api for 1.6? If so, maybe it would make more sense to implement adding new items using that api?

[bill]

That's the plan, to have the ​new api in 1.6, so I agree it would make sense to follow that API.

[bill]

I've got #12373 assigned to me for FilteringSelect to point to the new store API. (Feel free to grab it if you can get to it before me; it should be in 1.7 in either case.)

[zuzusik]

Replying to guest:

I defined a FilteringSelect? dijit in html (using option tags instead of a datastore.). I've discovered that it is not possible to add a new item to the filtering select after it has been parsed.

Something like dijit.byId('id').addItem(name, value) really needs to be added.

At the very least there needs to be a way to add an item to the underlying default datastore.

This could be done in next way:

var a = dijit.byNode(yourWidgetNode);
dojo.place('<option value="new">New Option</option>', a.store.root, 'last'); //adding
dojo.destroy(dojo.query('[value="' + valueToRemove + '"]', a.store.root)[0]); //removing

a.store.root - simple html select with options and filtering select watches it.

[bill]

Isn't this working already? dijit/form/DataList, the class used internally for inline <option> tags, extends dojo/store/Memory, so you should be able to add data to it, via myFilteringSelect.store.put(...).

I'll close this but if I misunderstood something you can reopen.