Opened 11 years ago

Closed 7 years ago

#6728 closed defect (fixed)

Safari3, dojo._getMarginExtents error.

Reported by: guest Owned by: bill
Priority: high Milestone: 1.8
Component: HTML Version: 1.1.0
Keywords: Cc:
Blocked By: Blocking:

Description

the hack solution on that function seems does not need any more.

Change History (6)

comment:1 Changed 11 years ago by bill

Refs #3515 which added this code:

if(d.isSafari && (s.position != "absolute")){
	// FIXME: Safari's version of the computed right margin
	// is the space between our right edge and the right edge 
	// of our offsetParent. 
	// What we are looking for is the actual margin value as 
	// determined by CSS.
	// Hack solution is to assume left/right margins are the same.
	r = l;
}

Base safari bug is https://bugs.webkit.org/show_bug.cgi?id=13343. That bug isn't closed yet but perhaps was fixed?

comment:2 Changed 11 years ago by bill

Milestone: tbd

mark all (open) tickets w/blank milestones to be "tbd"; their milestones need to be set to a version number or to "future"

comment:3 Changed 11 years ago by dylan

Milestone: tbdfuture

comment:4 Changed 7 years ago by Adam Peller

Keywords: needsreview added
Milestone: futuretbd

Safari bug finally got closed (in 2011). Perhaps this path can be removed?

comment:5 Changed 7 years ago by bill

Keywords: needsreview removed
Milestone: tbd1.8
Owner: changed from sjmiles to bill
Status: newassigned

I agree, I'll remove it. I tested and it's working without that code. Looks like the fix got put into Safari5.

comment:6 Changed 7 years ago by bill

Resolution: fixed
Status: assignedclosed

In [27852]:

Remove no-longer needed workaround code. Refs #3515, fixes #6728 !strict. Tested using test_safari_simple.html from #3515, plus dojo/tests/runTests.html, on chrome and safari.

Note: See TracTickets for help on using tickets.