Opened 11 years ago

Closed 11 years ago

#6707 closed defect (fixed)

Editor.getValue() chokes is HTML attribute has a numeric parameter.

Reported by: guest Owned by: liucougar
Priority: high Milestone: 1.2
Component: Editor Version: 1.1.0
Keywords: Cc:
Blocked By: Blocking:

Description (last modified by bill)

Specifically, this line of dijit._editor.getNodeHtml(/*DomNode?*/) will croak:

output += ' '+attr[0]+'="'+dijit._editor.escapeXml(attr[1],true)+'"';

However, the following works:

output += ' '+attr[0]+'="'+dijit._editor.escapeXml(attr[1].toString(),true)+'"';

This is under IE7 on Windows XP with Dojo 1.1.0 release.

You can contact me at jfrisby@….

Change History (5)

comment:1 Changed 11 years ago by guest

In case my email address was filtered, and not just hidden -- it's jfrisby at mac dot com.

comment:2 Changed 11 years ago by bill

Component: GeneralEditor
Description: modified (diff)
Milestone: 1.2
Owner: changed from anonymous to liucougar

Hi, actually the email is available to people w/logins into the bug database. So I guess this is a problem when the text you are editing is a just a number, like "5", rather than having a number embedded like "i am 5", right?

comment:3 Changed 11 years ago by guest

Not the text -- the value of an attribute on an HTML element in the rich text editor document.

I.E. <img height=5>, as opposed to <img height="5">; although there seem to be some annoying complexities about when the browser converts attrs to strings.

For example, in this case the problem seems to happen if I do 'foo.height="0px"' (where foo is a DOM element that is to be inserted into the editor), but not if I do 'foo.setAttribute("height", "0px")'.

comment:4 Changed 11 years ago by jeffg

FYI: I can also be a point of contact on jfrisby's issues as he's helping me out on a number of issues...

comment:5 Changed 11 years ago by liucougar

Resolution: fixed
Status: newclosed

(In [13902]) fixes #6707: make sure the values for attributes are strings for IE

Note: See TracTickets for help on using tickets.