Opened 11 years ago

Closed 11 years ago

#6685 closed enhancement (fixed)

adding box-model to dijit._base.sniff

Reported by: Sam Foster Owned by: bill
Priority: high Milestone: 1.2
Component: Dijit Version: 1.1.0
Keywords: Cc: danta, nonken
Blocked By: Blocking:

Description

Semantics would be: .dj_contentbox { ... } .dj_borderbox { ... }

Its possibly redundant with dj_iequirks / dj_ie, but more explicit? Says what it means, rather than infering via the browser name. And its future-proof.

Attachments (2)

sniff_20080505.patch (686 bytes) - added by Sam Foster 11 years ago.
[PATCH] [CLA] adds dojo.boxModel class to dijit/_base/sniff.js
sniff_tests_20080506.patch (5.0 KB) - added by Sam Foster 11 years ago.
[PATCH] [CLA] fixed IE parse error, added 2 test files (visual and doh); adds correction to size for border-box box model (i.e. IE and IE7 in quirks mode)

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by Sam Foster

Attachment: sniff_20080505.patch added

[PATCH] [CLA] adds dojo.boxModel class to dijit/_base/sniff.js

comment:1 Changed 11 years ago by bill

This needs more testing; it doesn't even load on IE.

Changed 11 years ago by Sam Foster

Attachment: sniff_tests_20080506.patch added

[PATCH] [CLA] fixed IE parse error, added 2 test files (visual and doh); adds correction to size for border-box box model (i.e. IE and IE7 in quirks mode)

comment:2 Changed 11 years ago by Sam Foster

sniff_tests_20080506.patch added.(Ignore file description - copy/paste error). This adds the boxModel css hook as before (fixed IE syntax error), and includes 2 test files for quirks and standards mode rendering.

I've used a ruler image in there for visual inspection/comparison - that's hosted on my site - let me know if you want to add that somewhere in dijit/dojo for local/offline testing. I have a bunch of them actually at http://sam-i-am.com/work/sandbox/measuring/

comment:3 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

(In [13602]) Add .dijitContentBox/.dijitBorderBox flags to <html> in addition to .dj_ie6 etc. Patch from Sam Foster (CLA on file).

Fixes #6685, refs #6108.

Note: See TracTickets for help on using tickets.