Opened 13 years ago
Closed 13 years ago
#6682 closed defect (fixed)
dojox.image.Lightbox - dialog rendering is off in IE
Reported by: | Sam Foster | Owned by: | dante |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Dojox | Version: | 1.1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
For me this manifests itself as the footer toolbar being present in the DOM but not visible. Others have reported other issues - presumably variation is introduced by different css, quirks/standards mode.
Attachments (2)
Change History (7)
Changed 13 years ago by
Attachment: | 6682_lightbox_20080504.patch added |
---|
comment:1 Changed 13 years ago by
6682_lightbox_20080504.patch has a fairly simplistic patch to the issue I was seeing. Basically, the resizeTo method was setting size on the outer element and not correcting for any padding/border on it. So in IE it ended up being smaller by 2x border, padding width. Ideally, we'd calculate this value rather than hard-code here.
comment:2 follow-up: 3 Changed 13 years ago by
I'm not sure if this is related or not - but I have ie6/ie7 issues with this URL:
http://www.spiritualpaths.net/sitepages/pid2045.php?ltemplate=image_demo&pageId=2045&item_id=3
If you click the icon to the right of the word "Photo:" a title pane with image thumbnails appears - click one of the images for a lightbox. In firefox2 works like a champ - in ie it either sticks in the lower right or doesn't have a footer. I will try applying sfoster's patch.
Please add [email protected]… to CC list.
Thanks
comment:3 Changed 13 years ago by
Replying to guest:
I'm not sure if this is related or not - but I have ie6/ie7 issues with this URL:
http://www.spiritualpaths.net/sitepages/pid2045.php?ltemplate=image_demo&pageId=2045&item_id=3
If you click the icon to the right of the word "Photo:" a title pane with image thumbnails appears - click one of the images for a lightbox. In firefox2 works like a champ - in ie it either sticks in the lower right or doesn't have a footer. I will try applying sfoster's patch.
Please add [email protected]… to CC list.
Thanks
A little more information found - if I add &pb_debug_dojo=1 to the end of the URL it loads dojo.js.uncompressed.js (not my build) with debug=true in djConfig. This yeilded some errors in the ie console (see attached image)
Exception in animation handler for: onAnimate [ Error: Invalid argument. ]
Thanks
comment:4 Changed 13 years ago by
Think this is a different Lightbox issue - applied sfoster's patch and now the image is in the middle of the page but still with the onAnimate exception and greyed out. (btw, this is against 1.1 release)
Let me know if you want a separate trac filed.
comment:5 Changed 13 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
[PATCH] [CLA] adds correction to size for border-box box model (i.e. IE and IE7 in quirks mode)