Opened 11 years ago

Closed 11 years ago

#6682 closed defect (fixed)

dojox.image.Lightbox - dialog rendering is off in IE

Reported by: Sam Foster Owned by: dante
Priority: high Milestone: 1.2
Component: Dojox Version: 1.1.0
Keywords: Cc:
Blocked By: Blocking:

Description

For me this manifests itself as the footer toolbar being present in the DOM but not visible. Others have reported other issues - presumably variation is introduced by different css, quirks/standards mode.

Attachments (2)

6682_lightbox_20080504.patch (1000 bytes) - added by Sam Foster 11 years ago.
[PATCH] [CLA] adds correction to size for border-box box model (i.e. IE and IE7 in quirks mode)
lightbox.png (212.0 KB) - added by guest 11 years ago.
Screenshot of ie6 errors on lightbox

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Sam Foster

[PATCH] [CLA] adds correction to size for border-box box model (i.e. IE and IE7 in quirks mode)

comment:1 Changed 11 years ago by Sam Foster

6682_lightbox_20080504.patch has a fairly simplistic patch to the issue I was seeing. Basically, the resizeTo method was setting size on the outer element and not correcting for any padding/border on it. So in IE it ended up being smaller by 2x border, padding width. Ideally, we'd calculate this value rather than hard-code here.

comment:2 Changed 11 years ago by guest

I'm not sure if this is related or not - but I have ie6/ie7 issues with this URL:

http://www.spiritualpaths.net/sitepages/pid2045.php?ltemplate=image_demo&pageId=2045&item_id=3

If you click the icon to the right of the word "Photo:" a title pane with image thumbnails appears - click one of the images for a lightbox. In firefox2 works like a champ - in ie it either sticks in the lower right or doesn't have a footer. I will try applying sfoster's patch.

Please add josh@… to CC list.

Thanks

comment:3 in reply to:  2 Changed 11 years ago by guest

Replying to guest:

I'm not sure if this is related or not - but I have ie6/ie7 issues with this URL:

http://www.spiritualpaths.net/sitepages/pid2045.php?ltemplate=image_demo&pageId=2045&item_id=3

If you click the icon to the right of the word "Photo:" a title pane with image thumbnails appears - click one of the images for a lightbox. In firefox2 works like a champ - in ie it either sticks in the lower right or doesn't have a footer. I will try applying sfoster's patch.

Please add josh@… to CC list.

Thanks

A little more information found - if I add &pb_debug_dojo=1 to the end of the URL it loads dojo.js.uncompressed.js (not my build) with debug=true in djConfig. This yeilded some errors in the ie console (see attached image)

Exception in animation handler for: onAnimate [ Error: Invalid argument. ]

Thanks

Changed 11 years ago by guest

Attachment: lightbox.png added

Screenshot of ie6 errors on lightbox

comment:4 Changed 11 years ago by guest

Think this is a different Lightbox issue - applied sfoster's patch and now the image is in the middle of the page but still with the onAnimate exception and greyed out. (btw, this is against 1.1 release)

Let me know if you want a separate trac filed.

comment:5 Changed 11 years ago by dante

Resolution: fixed
Status: newclosed

(In [14277]) fixes #6682 - add in padding calculations for IE when in content-box mode to the footer shows up propertly. also makes _LightboxDialog a public class, as it is very useful without the "degradable" dojox.image.Lightbox wrapper

Note: See TracTickets for help on using tickets.