Opened 13 years ago
Closed 11 years ago
#6635 closed task (fixed)
Tree: replace icons w/something more colorful
Reported by: | bill | Owned by: | nonken |
---|---|---|---|
Priority: | high | Milestone: | 1.5 |
Component: | Dijit - LnF | Version: | 1.1.0 |
Keywords: | ibm | Cc: | nonken |
Blocked By: | Blocking: |
Description
- Problem: refine design of treeview icons ( e.g. open folder opens wrong direction; +/- icons- competing gradient style to the folder icons)
- Recommendation: Use open source Eclipse folder and +/-icons. (see revised assets)
Current:
New:
Taken from IBM Design Leadership recommendations.
Attachments (2)
Change History (13)
Changed 13 years ago by
Attachment: | current.gif added |
---|
Changed 13 years ago by
comment:1 Changed 13 years ago by
comment:2 Changed 13 years ago by
PS: also need to make sure licensing is OK. Dojo usually asks for images to be explicitly donated, even if they come from open source.
comment:3 Changed 13 years ago by
Cc: | nonken added |
---|
comment:4 Changed 13 years ago by
Apparently licensing is OK if we add a license file, see http://dojotoolkit.org/book/dojo-book-0-4/part-9-dojo-community/intellectual-property-policies and http://article.gmane.org/gmane.comp.web.dojo.devel/8531
As per LnF, note that 0.4 (see http://download.dojotoolkit.org/release-0.4.2/dojo-0.4.2p1-widget/tests/widget/treeV3/docIcon1.html) had colorful icons but we intentionally changed them to gray (AFAICT) to make them blend better with various color schemes.
comment:5 Changed 13 years ago by
I'm not crazy about the Eclipse icons, personally. We could just incorporate some of this input for Tundra by flipping the icons and reconsidering the gradients (I think I like the gradients)
Also, I'd hate to include a license file just for one set of icons. Even though there shouldn't be any issue here, it complicates our licensing situation by just having another reference to consider.
comment:6 Changed 13 years ago by
comment:7 Changed 13 years ago by
Owner: | changed from bill to nonken |
---|
I asked Torrey about this and he said he didn't have any strong views; he said "I think the yellow probably stands out a little more which might be better for a tree component". So, Nikolai, it's up to you. At a minimum we should flip the gradient on the open icon so it matches the closed icon and the folder icons.
As Adam said it's not worth including a LICENSE file when we can change the icons ourselves.
comment:8 Changed 13 years ago by
Milestone: | 1.2 → 1.3 |
---|---|
Status: | new → assigned |
Until we decide about whether to use the fam fam icon set or not we should stick to the icon we have. Agree though that current tree icons are a bit grey
comment:9 Changed 12 years ago by
Milestone: | 1.3 → 1.4 |
---|
comment:10 Changed 12 years ago by
Milestone: | 1.4 → 1.5 |
---|
comment:11 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
This has been done for the new claro theme, not worth doing for tundra (especially if tundra users don't want to change).
We'll need to talk about this one. Tundra was specifically designed to be drab so that it matches any corporate color scheme, like IBM's blue or Sitepen's green (ie, the main color used on the website). Not sure if this defeats that purpose. Note that other themes like nihilo have different icons already: http://download.dojotoolkit.org/release-1.1.0/dojo-release-1.1.0/dijit/tests/test_Tree.html?theme=nihilo