Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#6629 closed enhancement (wontfix)

Editor insertImage plugin considers valid URL invalid

Reported by: guest Owned by: liucougar
Priority: high Milestone: 1.2
Component: Editor Version: 1.1.0
Keywords: Editor insertImage invalid URL Cc: josh@…
Blocked By: Blocking:

Description

When using the insertImage plugin for dijit.Editor, the popup considers the following an invalid image URL path:

/images/edit.gif

It shows an invalid URL, but if you press OK anyway, the image is shown.

I think it's fairly common to use an image src path starting with a slash for the site's root directory, hopefully an easy fix.

Thanks,

Josh

Change History (4)

comment:1 Changed 12 years ago by Adam Peller

Milestone: 1.2

comment:2 Changed 11 years ago by bill

Resolution: wontfix
Status: newclosed
Type: defectenhancement

Nikolai is working on better image insert dialogs so maybe this will be addressed then, or rather become a non-issue.

But as per this actual ticket, I'm not interested in dijit supporting relative URLs for the link dialog or image dialog, as they would be confusing as to whether they referred to the client machine (running the browser) or the server machine. Right now, we only support full URLs. Sorry.

comment:3 in reply to:  2 Changed 11 years ago by Josh Trutwin

Replying to bill:

Nikolai is working on better image insert dialogs so maybe this will be addressed then, or rather become a non-issue.

Is this what will be dojox.Editor in 1.2?

But as per this actual ticket, I'm not interested in dijit supporting relative URLs for the link dialog or image dialog, as they would be confusing as to whether they referred to the client machine (running the browser) or the server machine. Right now, we only support full URLs. Sorry.

I would argue that an href starting with a slash / is an absolute URL, just absolute to the current domain.

That said, I'll see what the new editor does for this and followup if needed.

Thanks,

Josh

comment:4 Changed 11 years ago by bill

I'd say that /foo/bar is relative to the current domain but I don't want to debate semantics. What I meant to say was that I'm not interested in supporting anything but full URLs.

Actually, supporting URLs at all seems pretty useless to me; other editors work is by displaying the list of images already on the server (probably that the user has uploaded) and let's you pick one. That's the kind of thing Nikolai is working on, and he was planning to check in an initial stage of it into DojoX for 1.2 (but not complete, IIUC).

Note: See TracTickets for help on using tickets.