Opened 14 years ago
Closed 14 years ago
#6607 closed defect (fixed)
dojox.flash - style of surrounding div not set in IE
Reported by: | guest | Owned by: | dylan |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Dojox | Version: | 1.1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
dojox\flash\_base.js -> Method "write" includes following code:
dojo.connect(dojo, "loaded", dojo.hitch(this, function(){ var div = document.createElement("div"); div.setAttribute("id", this.id + "Container"); div.setAttribute("style", containerStyle); div.innerHTML = objectHTML; .... }));
The line div.setAttribute("style", containerStyle);
does not work in IE and causes the flash object to show up in the page, because the object is not properly placed.
It should probably be replaced by
div.style.cssText = containerStyle;
which works in FireFox? and IE (I did not test Safari and so on ...)
Change History (5)
comment:1 Changed 14 years ago by
Owner: | changed from anonymous to Brad Neuberg |
---|
comment:2 Changed 14 years ago by
Component: | General → Dojox |
---|
comment:3 Changed 14 years ago by
Owner: | changed from Brad Neuberg to bradneuberg |
---|
comment:4 Changed 14 years ago by
Milestone: | → 1.2 |
---|---|
Owner: | changed from bradneuberg to dylan |
Status: | new → assigned |
comment:5 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
(In [14310]) fixes #6607, use .style= rather than setAttribute() because it is more concise and works everywhere