#660 closed defect (fixed)
Bad positioning of popups in Editor widget
Reported by: | Owned by: | dylan | |
---|---|---|---|
Priority: | low | Milestone: | |
Component: | Widgets | Version: | 0.2 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
The Editor widget does not take into account the possibility of scrollable pages in the ColorDialog? popups.
In ColorPalette?.js the...
showDialog: function (e) {
dojo.widget.html.ToolbarColorDialog?.superclass.showDialog.call (this, e); var x = dojo.html.getAbsoluteX(this.domNode); var y = dojo.html.getAbsoluteY(this.domNode) + dojo.html.getInnerHeight(this.domNode); this.dialog.showAt(x, y);
},
...is the code that activates the popup color dialog. The dojo.html.getAbsoluteX and dojo.html.getAbsoluteY are the ones that calculate the coordinates, but they are not instructed to take into account the scroll feature. The code should be:
showDialog: function (e) {
dojo.widget.html.ToolbarColorDialog?.superclass.showDialog.call(this, e); var x = dojo.html.getAbsoluteX(this.domNode, true); var y = dojo.html.getAbsoluteY(this.domNode, true) + dojo.html.getInnerHeight(this.domNode); this.dialog.showAt(x, y);
},
Tried it and works perfectly.
Thanks
Change History (4)
comment:1 Changed 15 years ago by
comment:2 Changed 15 years ago by
Milestone: | → 0.4 |
---|---|
Owner: | changed from anonymous to dylan |
Status: | new → assigned |
comment:3 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
thanks, fixed in [4663]