Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#660 closed defect (fixed)

Bad positioning of popups in Editor widget

Reported by: pviegas@… Owned by: dylan
Priority: low Milestone:
Component: Widgets Version: 0.2
Keywords: Cc:
Blocked By: Blocking:

Description

The Editor widget does not take into account the possibility of scrollable pages in the ColorDialog? popups.

In ColorPalette?.js the...

showDialog: function (e) {

dojo.widget.html.ToolbarColorDialog?.superclass.showDialog.call (this, e); var x = dojo.html.getAbsoluteX(this.domNode); var y = dojo.html.getAbsoluteY(this.domNode) + dojo.html.getInnerHeight(this.domNode); this.dialog.showAt(x, y);

},

...is the code that activates the popup color dialog. The dojo.html.getAbsoluteX and dojo.html.getAbsoluteY are the ones that calculate the coordinates, but they are not instructed to take into account the scroll feature. The code should be:

showDialog: function (e) {

dojo.widget.html.ToolbarColorDialog?.superclass.showDialog.call(this, e); var x = dojo.html.getAbsoluteX(this.domNode, true); var y = dojo.html.getAbsoluteY(this.domNode, true) + dojo.html.getInnerHeight(this.domNode); this.dialog.showAt(x, y);

},

Tried it and works perfectly.

Thanks

Change History (4)

comment:1 Changed 13 years ago by dylan

thanks, fixed in [4663]

comment:2 Changed 13 years ago by dylan

Milestone: 0.4
Owner: changed from anonymous to dylan
Status: newassigned

comment:3 Changed 13 years ago by dylan

Resolution: fixed
Status: assignedclosed

comment:4 Changed 12 years ago by (none)

Milestone: 0.4

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.