Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6595 closed enhancement (fixed)

Add a new data store for Google search

Reported by: sos Owned by: Jared Jurkiewicz
Priority: high Milestone: 1.2
Component: DojoX Data Version: 1.1.0
Keywords: Cc:
Blocked By: Blocking:

Description

Google make their search API available as a RESTful service. A dojox.data store should be written to access it.

Attachments (9)

GoogleSearch.patch (34.1 KB) - added by sos 11 years ago.
Patch to implement this feature
GoogleSearch_multipleStores.patch (45.9 KB) - added by sos 11 years ago.
Update patch that implements multiple different stores, one for each type of search
dojox.data.GoogleSearchStore_20080501.patch (49.2 KB) - added by Jared Jurkiewicz 11 years ago.
My version of the patch with extra demo + some attempted fixes.
dojox.data.GoogleSearchStore_20080501_2.patch (49.2 KB) - added by sos 11 years ago.
Updated patch with paging errors fixed
dojox.data.GoogleSearchStore_20080501_3.patch (53.8 KB) - added by sos 11 years ago.
Patch with more fixes, and tests for Image gallery and Slideshow
dojox.data.GoogleSearchStore_20080501_4.patch (54.1 KB) - added by Jared Jurkiewicz 11 years ago.
More cleanup. Fixed a few accidental globals, one invalid test, some structure, and jslint complaints.
GoogleSearch_args.patch (3.9 KB) - added by sos 11 years ago.
Fixes checking of contructor args
GoogleFeedStore_Initial.patch (30.6 KB) - added by sos 11 years ago.
Patch that implements a store that accesses Google's Feed API. Use this instead of the previous patch!
GoogleSearch_dijitRequire.patch (5.7 KB) - added by sos 11 years ago.
Performance improvement for the demos

Download all attachments as: .zip

Change History (19)

Changed 11 years ago by sos

Attachment: GoogleSearch.patch added

Patch to implement this feature

comment:1 Changed 11 years ago by sos

I've discovered a bug with the store, relating to using non-web based search, e.g. blogs. This will be fixed tonight, and a new patch submitted

Changed 11 years ago by sos

Update patch that implements multiple different stores, one for each type of search

comment:2 Changed 11 years ago by Jared Jurkiewicz

Will look at this soon! This sounds really cool. Thanks for doing the initial work on it. :)

comment:3 Changed 11 years ago by Jared Jurkiewicz

Looked at it a bit, fixed a few things, added a demo that attaches it to grid, tried to remove the usage of simpleFetch, though I don't know if that is necessary

Overall, I think you have some bugs in the paging mechanism. Start/count don't work quite as expected when it is trying to get subsets. This shows up particularly in grid. For some reason it only shows the first page. Could you take a look at your paging logic again and see why it is acting funny? I looked over it some, and will do so more later, but I haven't figured it quite out yet.

Changed 11 years ago by Jared Jurkiewicz

My version of the patch with extra demo + some attempted fixes.

comment:4 Changed 11 years ago by sos

Sure, will look in to it. Do you know of any specific tests, or combination of tests, that it fails? I included all the standard tests, which it passes. Perhaps we need to extend the basic set of tests for more coverage.

Changed 11 years ago by sos

Updated patch with paging errors fixed

Changed 11 years ago by sos

Patch with more fixes, and tests for Image gallery and Slideshow

comment:5 Changed 11 years ago by sos

Patch dojox.data.GoogleSearchStore_20080501_3.patch also includes a fix for dojox.image.Gallery, where it was broken if a store other than one of the Flickr stores was used.

Changed 11 years ago by Jared Jurkiewicz

More cleanup. Fixed a few accidental globals, one invalid test, some structure, and jslint complaints.

comment:6 Changed 11 years ago by Jared Jurkiewicz

Resolution: fixed
Status: newclosed

(In [13527]) Awesome collaborative work from Shane O'Sullivan and Jared J. fixes #6595 \!strict

comment:7 Changed 11 years ago by Jared Jurkiewicz

(In [13538]) Fix to demo with grid, css path issue. refs #6595

Changed 11 years ago by sos

Attachment: GoogleSearch_args.patch added

Fixes checking of contructor args

Changed 11 years ago by sos

Patch that implements a store that accesses Google's Feed API. Use this instead of the previous patch!

comment:8 Changed 11 years ago by Jared Jurkiewicz

(In [13592]) Minor updates to GoogleSearchStore? + the GoogleFeedStore? extension. Many thanks ot Shane for his hard work on them. refs #6595 \!strict

comment:9 Changed 11 years ago by Jared Jurkiewicz

Added in Shane's addition after a quick review. Tested it all on FF 2, IE 6, Seamonkey 1.1.2, and Safari 3.1

comment:10 Changed 11 years ago by Jared Jurkiewicz

Milestone: 1.2

Changed 11 years ago by sos

Performance improvement for the demos

Note: See TracTickets for help on using tickets.