#6592 closed defect (fixed)
InlineEditBox: does not replace " with " on editor creation
Reported by: | guest | Owned by: | bill |
---|---|---|---|
Priority: | high | Milestone: | 1.2 |
Component: | Dijit | Version: | 1.1.0 |
Keywords: | Cc: | ||
Blocked By: | Blocking: |
Description
InlineEditBox? will convert a typed " (quote) character into a " entity, but does not perform the reverse (convert a " entity into a " char) on editor creation.
save: function() has code to replace " with " edit: function() does not handle "/"
Change History (5)
comment:1 Changed 12 years ago by
Resolution: | → worksforme |
---|---|
Status: | new → closed |
Summary: | InlineEditBox does not replace " with " on editor creation → InlineEditBox: does not replace " with " on editor creation |
comment:2 Changed 12 years ago by
Resolution: | worksforme |
---|---|
Status: | closed → reopened |
On the latest nightly on archive.dojotoolkit.org if I type
Bob "King of Refrigerators" Vance
into any of the inline edit boxes, then click somewhere else (so the InlineEditBox? writes the changes back to the dom), then click in the editor to edit again it has " entities instead of " characters.
In the InlineEditBox?.js file. Line 134 (in the _edit function): this.value.replace(/\s*\r?\n\s*/g,"").replace(/<br\/?>/gi,"\n").replace(/>/g,">").replace(/</g,"<").replace(/&/g,"&"));
should be: this.value.replace(/\s*\r?\n\s*/g,"").replace(/<br\/?>/gi,"\n").replace(/>/g,">").replace(/</g,"<").replace(/&/g,"&").replace(/"/g,"\""));
Compared with line 209 (in the save function) where it replaces " with "
Tested this to fail in FF2
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:5 Changed 11 years ago by
Milestone: | → 1.2 |
---|
marking tickets closed in the last three months w/blank milestone to milestone 1.2.
I tried modifying test_InlineEditBox.html to say
instead of
and it worked fine on IE6, FF3, and Safari 3.1. I'm going to close this as "works for me" but if you have a test case that fails reopen the bug and attach the test case using the Attach File button.