Changes between Initial Version and Version 1 of Ticket #6572


Ignore:
Timestamp:
Apr 20, 2008, 6:38:30 PM (12 years ago)
Author:
bill
Comment:

I agree, makes sense to me for buttons to be the same height as other form widgets, and seems to be the standard. I think we can do that easily by adjusting Button font-size and padding.

As per your final comment that "Button height should default to 100% of the current line-height unless otherwise specified by the widget user.", there are couple issues with that so I don't think we can do it:

  • button height is determined by the button contents, so for example if the button contains an icon it will likely be taller
  • not sure inline/inline-block elements have concept of line-height; AFAIK they just have their own height.
  • as per 4/8/2008 dijit meeting (I wrote the results in #6307), input widgets won't inherit font-size or anything from the document. Thus if Button inherits height but the TextBox doesn't, they are likely to not match, defeating the original purpose. (Note however that Ctrl-+ will adjust the size of all elements on the page, even on legacy browsers, since font-size is specified in "em".)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6572 – Description

    initial v1  
    1 by default, dijit buttons are much larger than the surrounding line-height. As a result, placing them inline with other input elements (including input dijits) results in badly mis-shapen layouts. For example, go to themeTester.html, open the "popups and alerts" accordion on the left, and then click on "Show Modal Dialog". The contents of the resulting dialog places a ComboBox in the same line as an inline button, and the size issues are clearly visible as a result. Button height should default to 100% of the current line-height unless otherwise specified buy the widget user.
     1by default, dijit buttons are much larger than the surrounding line-height. As a result, placing them inline with other input elements (including input dijits) results in badly mis-shapen layouts. For example, go to themeTester.html, open the "popups and alerts" accordion on the left, and then click on "Show Modal Dialog".
     2
     3[[Image(button_sizing.png)]]
     4
     5The contents of the resulting dialog places a ComboBox in the same line as an inline button, and the size issues are clearly visible as a result. Button height should default to 100% of the current line-height unless otherwise specified by the widget user.