Changes between Initial Version and Version 5 of Ticket #6524


Ignore:
Timestamp:
Jul 24, 2008, 9:17:12 AM (13 years ago)
Author:
bill
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6524

    • Property Owner set to bill
    • Property Status changed from new to assigned
    • Property Milestone changed from to 1.2
    • Property Summary changed from Dialog.show is slow for dialogs with many nested elements to Dialog: show() is slow for dialogs with many nested elements
  • Ticket #6524 – Description

    initial v5  
    13132. Changed dijit._DialogMixin._getFocusItems to call dijit._getTabNavigable directly instead of calling it implicitely twice due to the
    1414calls to getFirstInTabbingOrder/getLastInTabbingOrder:
    15 
     15{{{
    1616_getFocusItems: function(/*Node*/ dialogNode){
    1717                        // find focusable Items each time a dialog is opened
     
    3030                        }
    3131                }
    32 
     32}}}
    3333Result:
    34341502.8 ms (FF2), 2559.6 ms (IE6) (average of 5 tries)
     
    3737
    3838simply changing:
     39
     40{{{
    3941if(isShown){ walkTree(child) }
     42}}}
    4043
    4144to
    4245
     46{{{
    4347if(isShown && child.nodeName.toUpperCase() != 'SELECT'){ walkTree(child) }
     48}}}
    4449
    4550Result: