Opened 14 years ago

Closed 12 years ago

#6511 closed defect (fixed)

Dialog: focus doesn't go to first widget when dialog content loaded via href

Reported by: ptbrunet Owned by: Becky Gibson
Priority: high Milestone: 1.5
Component: Dijit Version: 1.1.0
Keywords: a11y Cc: Becky Gibson
Blocked By: Blocking:

Description

There is one href case in test_Dialog.html. It uses case 3 in layout/getResponse.php to populate the dialog. If I change case 3 to add a button to it you'll notice that the focus doesn't go to the button when the dialog loads.

Attachments (2)

6511.patch​ (3.1 KB) - added by Becky Gibson 12 years ago.
6511_test.patch​ (5.7 KB) - added by Becky Gibson 12 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 14 years ago by bill

Milestone: 1.1.1 → 1.2

Is there a reason this needs to go into 1.1.1?

comment:2 Changed 13 years ago by dylan

Milestone: 1.2 → future

comment:3 Changed 12 years ago by Becky Gibson

Keywords: a11y added

Changed 12 years ago by Becky Gibson

Attachment: 6511.patch​ added

comment:4 Changed 12 years ago by Becky Gibson

Resolution: → fixed
Status: new → closed

(In [21776]) fixes #6511 - find focusable items and set focus in onLoad event handler for dialogs with href parameter.

comment:5 Changed 12 years ago by bill

Milestone: future → 1.5
Resolution: fixed
Status: closed → reopened

Unfortunately Dialog_a11y.html is getting an error on IE8 now (and IE6 too I think, and maybe other browsers), on the a11yFirstFocus test.

comment:6 Changed 12 years ago by bill

Owner: set to Becky Gibson
Status: reopened → new
Summary: Dialog - focus doesn't go to first widget when dialog content loaded via href → Dialog: focus doesn't go to first widget when dialog content loaded via href

Changed 12 years ago by Becky Gibson

Attachment: 6511_test.patch​ added

comment:7 Changed 12 years ago by Becky Gibson

updated tests to account for href dialog receiving focus. Tested on IE 8, FF 3.6.2, and Safari 4. OK to check in?

comment:8 Changed 12 years ago by bill

Cool, looks good to me (although I didn't actually try it, but I'll take your word for it). Getting rid of the dojo.connect() calls is good, it's too tricky (or perhaps impossible) to do a dojo.connect() between the time the href finishes loading and the Dialog focuses the first element.

comment:9 Changed 12 years ago by Becky Gibson

Resolution: → fixed
Status: new → closed

(In [21818]) fixes #6511 - updated tests to check for correct focus on dialog loaded from href

Note: See TracTickets for help on using tickets.