#6506 closed defect (fixed)
[patch] ComboBox: when drop down opened, escape shouldn't revert value, just close drop down
| Reported by: | bill | Owned by: | haysmark |
|---|---|---|---|
| Priority: | high | Milestone: | 1.2 |
| Component: | Dijit - Form | Version: | 1.1.0 |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: |
Description (last modified by )
When the drop down is open ESC should close it; hitting ESC an additional time should revert the value. At least arguably so (see forum discussion).
Currently, on test_ComboBox.html,
- in first combobox, erase the value and type "al"
- press down arrow key twice to get to "Alaska" (so that Alaska is also displayed in the input box)
- press ESC
At this point the drop down closes and the input box returns to "Iowa". Seems inconsistent w/how we are handling esc for other widgets with drop downs?
Attachments (1)
Change History (7)
comment:1 Changed 14 years ago by
| Description: | modified (diff) |
|---|
Changed 13 years ago by
| Attachment: | 6506.patch added |
|---|
comment:2 Changed 13 years ago by
| Owner: | changed from Douglas Hays to haysmark |
|---|---|
| Status: | new → assigned |
| Summary: | ComboBox: when drop down opened, escape shouldn't revert value, just close drop down → [patch] ComboBox: when drop down opened, escape shouldn't revert value, just close drop down |
comment:3 Changed 13 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Revision: 14220 Author: bill Date: 2:12:10 AM, Wednesday, July 02, 2008 Message: Fixes #6390: Can't search all in ComboBox? / FilteringSelect? Patch from Mark Hays. !strict
Modified : /dijit/trunk/form/ComboBox.js Modified : /dijit/trunk/tests/form/test_ComboBox.html
comment:4 Changed 13 years ago by
Actually I checked in your patch in [14221], which should have closed this ticket automatically.
comment:5 Changed 13 years ago by
Yeah it's weird that there was no message. I must have misclicked.
Revision: 14221 Author: bill Date: 2:24:05 AM, Wednesday, July 02, 2008 Message: Fixes #6506: ComboBox?: when drop down opened, escape shouldn't revert value, just close drop down Patch from Mark Hays. !strict
Modified : /dijit/trunk/form/ComboBox.js
comment:6 Changed 10 years ago by
| Component: | Dijit → Dijit - Form |
|---|
Fixes #6506. ComboBox? doesn't revert the value/close the parent dialog/etc when you press Escape and the ComboBox? menu is still open.