Using dojo.fx.combine in dojo.fx.chain throws errors

[guest]

When I do this:

var fx = [];
var d = 1500;
fx.push(dojo.fadeOut({ node:"a", duration:d }));
fx.push(dojo.fadeOut({ node:"b", duration:d }));
dojo.fx.chain([
	dojo.fx.combine(fx),
	dojo.fadeOut({ node:"c", duration:d })
]).play();

I get a TypeError?:

TypeError: second argument to Function.prototype.apply must be an arraydojo.xd.js

This only happens when I pass dojo.fx.combine as an argument. Stepping through the call, it appears that the arguments are getting "unwrapped" too many times somehow.

The animation still runs fine (the error gets squashed somewhere) but the error shows up in Firebug which is annoying in the least (it happens once per onAnimate call!).

[guest]

See the bug in action!

[guest]

I've posted the bug online so you can see it "work", not just the src in trac.

​http://stilleye.com/z/dojo-fx-bug.html

[bill]

mark all (open) tickets w/blank milestones to be "tbd"; their milestones need to be set to a version number or to "future"

[bitranch]

This error also occurs when using NodeList?-fx. For example, with this (assuming a class="foo" exists on some node in the document):

dojo.fx.chain([
    dojo.query(".foo").fadeOut(),
    dojo.query(".foo).fadeIn()
    ]).play();

The animation runs, followed by a exception:

exception in animation handler for: onAnimate
TypeError: second argument to Function.prototype.apply must be an array

NodeList?-fx builds its animation using dojo.fx.combine, so this is obviously exercising the same bug.

(This is with svn head as of today.)

[dante]

uhop - you did the current chain/combine implementation. Reassign back to me if you are unable to spend time on this. I've looked briefly, and nothing apparent jumped out at me.

[ashendw]

Just noticed this bug in some test code I was playing with.

In dojo/fx.js, the _baseObj._fire method is pushing through a numeric value to the onAnimate event rather than an args array. The bug can be made quiet by putting an arrayLike check before calling the "this[evt].apply(this,args)" but not sure why a non array is getting in there yet.

[ashendw]

Found it to be the way events are hitched in the _combine.

File dojo/fx.js

problem line:

this._connects.push(dojo.connect(this._pseudoAnimation, evt, dojo.hitch(this, "_fire", evt)));

rewrote it to:

this._connects.push(dojo.connect(this._pseudoAnimation, evt, dojo.hitch(this, function(){this._fire(evt,arguments)})));

Although it's less elegant, argument is passed correctly.

[Matt Sgarlata]

That change works great for me. Thanks!

[Eugene Lazutkin]

Fixed in [16040].