Opened 11 years ago

Closed 11 years ago

#6486 closed defect (fixed)

tundra.css affecting styles of non-dojo popup widgets in high contrast mode

Reported by: Becky Gibson Owned by: Becky Gibson
Priority: high Milestone: 1.1.1
Component: Accessibility Version: 1.1.0
Keywords: Cc: nonken, dante, davidb, Joseph Scheuhammer
Blocked By: Blocking:

Description

Dojo/Dijit?'s CSS appears to cause all non-dojo created popups in a page to switch to a background: transparent value when rendered in high contrast mode in IE. Firefox 2 renders all of these non-dojo popups with a transparent background so this is irrelevant for that browser.

Attachments (3)

testWithCSS.html (2.0 KB) - added by Becky Gibson 11 years ago.
testWithoutCSS.html (1.9 KB) - added by Becky Gibson 11 years ago.
6486.patch (1.1 KB) - added by Becky Gibson 11 years ago.
patch created against 1.1 branch

Download all attachments as: .zip

Change History (12)

Changed 11 years ago by Becky Gibson

Attachment: testWithCSS.html added

Changed 11 years ago by Becky Gibson

Attachment: testWithoutCSS.html added

comment:1 Changed 11 years ago by Becky Gibson

Cc: nonken added
Component: GeneralAccessibility
Milestone: 1.1.1
Owner: changed from anonymous to Becky Gibson

comment:2 Changed 11 years ago by davidb

Looked at this with clown and it seems this behaviour might be explained by this rule in dijit.css:

.dijit_a11y * {
	background-image:none !important;
	background-color:transparent !important;
}

comment:3 Changed 11 years ago by bill

I can see how that pattern is problematic (and note that it could affect more than just popups, right?). Not sure how to fix. Seems like we need a list of much more specific patterns that only match the widgets where this is necessary, like Toolbar?

comment:4 Changed 11 years ago by Becky Gibson

I removed the background-color:transparent from .dijit_a11y * and here are the issues I found in High contrast mode: In Firefox 2 no issues - high contrast functions properly

IE 7

  • dialog backgroun is opaque and should be semi-transparent
  • color palette image does not show but should
  • toolbar select buttons the initial value does not display
  • progress bar does not display properly

IE6 - testing in progress

Firefox 2 Images off mode:

  • Background colors will now display in images off mode - this is fine; background colors are only removed in high contrast mode.
  • the color palette imsages still display

comment:5 in reply to:  4 Changed 11 years ago by Becky Gibson

Replying to becky: I removed the background-color:transparent from .dijit_a11y * and here are the issues I found in High contrast mode: In Firefox 2 no issues - high contrast functions properly

IE 7

  • dialog backgroun is opaque and should be semi-transparent
  • color palette image does not show but should
  • --toolbar select buttons the initial value does not display-- This is a general issue and not specific to this change
  • progress bar does not display properly

IE6

  • color palette image does not show but should
  • borders missing around spinner arrows ( I can live with this)
  • progress bar has some border sizing issues but works the same in 1.1.0

Firefox 2 Images off mode:

  • Background colors will now display in images off mode - this is fine; background colors are only removed in high contrast mode.
  • the color palette imsages still display

comment:6 Changed 11 years ago by Becky Gibson

Status: newassigned

Changed 11 years ago by Becky Gibson

Attachment: 6486.patch added

patch created against 1.1 branch

comment:7 Changed 11 years ago by Becky Gibson

Cc: dante davidb Joseph Scheuhammer added

The changes to fix the problems that I found were fairly minor and all were within dijit.css. I'd appreciate it if the css gurus could take a look and any additional testing by folks would be appreciated.

comment:8 Changed 11 years ago by Becky Gibson

(In [13444]) refs #6486; removed background-transparent; from .dijit_a11y * so that the background of any floating elements that are not part of dojo are NOT transparent in high contrast mode. Had to tweak a few styles to get all dijits working properly in high contrast mode after the change.

comment:9 Changed 11 years ago by Becky Gibson

Resolution: fixed
Status: assignedclosed

(In [13484]) fixes #6486 removed background-color:transparent !important; from dijit_a11y * since it causes non dojo popups to be transparent in high contrast mode. Had to tweak a few other classes for proper high contrast support.

Note: See TracTickets for help on using tickets.