Opened 12 years ago

Closed 12 years ago

Last modified 9 years ago

#6481 closed enhancement (fixed)

[patch] [cla] Slide direction control for dojox.layout.RadioGroup.js

Reported by: guest Owned by: dante
Priority: high Milestone: 1.2
Component: DojoX Layout Version: 1.1.0
Keywords: Cc: stuff@…
Blocked By: Blocking:

Description

I have created a patch to enable controlling the slide direction when using the dojox.layout.RadioGroupSlide?

To use see the examples in the tests attached.

I have already had a CLA accepted for Paul Edmondson stuff at hootbah.co.uk

Patches made against the trunk rev 13290

Attachments (3)

RadioGroup.js.diff (1.5 KB) - added by guest 12 years ago.
dojox.layout.RadioGroup?.js diff
test_RadioGroup.html.diff (2.9 KB) - added by guest 12 years ago.
dojox.layout.tests.test_RadioGroup.html diff
radio.diff (9.8 KB) - added by dante 12 years ago.

Download all attachments as: .zip

Change History (7)

Changed 12 years ago by guest

Attachment: RadioGroup.js.diff added

dojox.layout.RadioGroup?.js diff

Changed 12 years ago by guest

Attachment: test_RadioGroup.html.diff added

dojox.layout.tests.test_RadioGroup.html diff

comment:1 Changed 12 years ago by bill

Summary: Slide direction control for dojox.layout.RadioGroup.js[patch] [cla] Slide direction control for dojox.layout.RadioGroup.js

comment:2 Changed 12 years ago by dante

Milestone: 1.2
Owner: changed from Adam Peller to dante

great.

I actually have a patch for this made up as an enhancement, but it worked by reading a custom slideFrom attribute on the child panes. would that not make more sense? I'd like personally to be able to control each individual pane. attached is my patch in progress, which might not show up properly as it lives in the old trunk repo.

Changed 12 years ago by dante

Attachment: radio.diff added

comment:3 Changed 12 years ago by dante

Resolution: fixed
Status: newclosed

(In [13709]) fixes #6481 - adds ability to specify direction of incoming slide based on new param mixed into _Widget. defaults to "random". Changes default hasButtons to false in hopes to deprecate soon, though test still uses it. also adds zTop var, to handle top zindex, because panes sliding in simply overlay the old widget now. also fixed an unreported bug about onShow firing too soon (now onEnd of the animation).

comment:4 Changed 9 years ago by bill

Component: DojoxDojoX Layout
Note: See TracTickets for help on using tickets.