Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#648 closed defect (fixed)

getBoxObjectFor returns a read only variable

Reported by: kleite@… Owned by: bill
Priority: high Milestone:
Component: General Version: 0.3
Keywords: Cc:
Blocked By: Blocking:

Description

Latest change to Style.js checks for Mozilla browser and uses the 'getBoxObjectFor' method for returning the node's location. 'getBoxObjectFor' returns a read only BoxObject? that cannot be updated which is tried later on in the ds.getAbsolutePosition method. The test_Button2.html file displays this defect.

The following patch will correct this issue:

Index: style.js

===================================================================

--- style.js (revision 3655)

+++ style.js (working copy)

@@ -285,7 +285,9 @@

}

}else if(document.getBoxObjectFor){

mozilla

  • ret = document.getBoxObjectFor(node);

+ var retBox = document.getBoxObjectFor(node); + ret.x = retBox.x; + ret.y = retBox.y;

}else{

if(nodeoffsetParent?){

var endNode;

Attachments (1)

stylejs.patch (421 bytes) - added by kleite@… 13 years ago.
Patch to Style.js

Download all attachments as: .zip

Change History (4)

Changed 13 years ago by kleite@…

Attachment: stylejs.patch added

Patch to Style.js

comment:1 Changed 13 years ago by bill

Owner: changed from anonymous to bill

Hmm, I did test this and was working for me. I can change it though. What version of FF are you using?

comment:2 Changed 13 years ago by bill

Milestone: 0.3release
Resolution: fixed
Status: newclosed

fixed in r3659.

comment:3 Changed 12 years ago by (none)

Milestone: 0.3release

Milestone 0.3release deleted

Note: See TracTickets for help on using tickets.