Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#6475 closed task (fixed)

Tree: folder icons too low

Reported by: bill Owned by: bill
Priority: high Milestone: 1.2
Component: Dijit - LnF Version: 1.1.0
Keywords: ibm Cc:
Blocked By: Blocking:

Description

The folder icons are too low, relative to the expando (+/-) icons.

Taken from IBM Design Leadership recommendations.

Attachments (2)

tree.png (6.1 KB) - added by bill 11 years ago.
6475_tree_themes_20080505.patch (1.5 KB) - added by Sam Foster 11 years ago.
[PATCH] [CLA] change to .dijitTreeExpando definition for tundra, soria, nihilo - from dijit/themes

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by bill

Attachment: tree.png added

comment:1 Changed 11 years ago by Sam Foster

Owner: changed from bill to Sam Foster

Changed 11 years ago by Sam Foster

[PATCH] [CLA] change to .dijitTreeExpando definition for tundra, soria, nihilo - from dijit/themes

comment:2 Changed 11 years ago by Sam Foster

Status: newassigned

6475_tree_themes_20080505.patch uses position and negative top margin to position the expando icon at the middle of the line-box whatever the font scale. IE just gets nudged with top: 2px as it doesnt have real inline-box, so it all lays out differently.

Note this patch doesnt touch the images - it might make the css less quirky, and those icons more re-usable if they didnt have the top "padding" embedded in them - and css is used to position. But.. it may be late in the day for that - people are no doubt using those images outside of this context already.

Tested: FF2, Safari 3.1, IE6, IE7 In FF3 (windows) it looks like the expando could be nudged 1px less (-6px vs. -7px) but I'm not attempting to workaround at this point.

comment:3 Changed 11 years ago by bill

Talked to sfoster about this on IRC. I'd like you (sfoster) to:

  • Remove the built-in padding inside the image files. It's a holdover from when the vertical line connecting together sibling elements was part of the expando icon image, and seems like it's better to bite the bullet and remove it.
  • Try to get IE to have inline-block formatting for the expando. Otherwise it's aligned at baseline and if the label gets too large (imagine a 100px high label), the expando will be too low.
  • agreed that middle of plus sign (the horizontal line) should align w/middle of text and middle of folder icon.

comment:4 Changed 11 years ago by bill

Owner: changed from Sam Foster to bill
Status: assignednew

comment:5 Changed 11 years ago by bill

Fixed by [14104]

comment:6 Changed 11 years ago by bill

Resolution: fixed
Status: newclosed

comment:7 Changed 11 years ago by bill

(In [14107]) add alt="" for a11y reasons (so screenreader skips the images). refs #6475.

Note: See TracTickets for help on using tickets.